Opened 6 months ago

Closed 5 months ago

#27010 closed enhancement (fixed)

py3: avoid .vertices() in methods _ford_fulkerson, edge_cut, bounded_outdegree_orientation and gomory_hu_tree

Reported by: dcoudert Owned by:
Priority: major Milestone: sage-8.7
Component: graph theory Keywords: py3, graph
Cc: tscrim, chapoton Merged in:
Authors: David Coudert Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 0240367 (Commits) Commit: 0240367bef781fc219655b3bacd60ffd291eb595
Dependencies: Stopgaps:

Description

We fix all doctests errors in py3 of methods bounded_outdegree_orientation and gomory_hu_tree of graph.py by avoiding calls to .vertices() in these methods and in methods edge_cut and _ford_fulkerson of generic_graph.py. This also fixes some doctests in generic_graph.py.

Change History (4)

comment:1 Changed 6 months ago by dcoudert

  • Branch set to public/27010_graph
  • Cc tscrim chapoton added
  • Commit set to 0240367bef781fc219655b3bacd60ffd291eb595
  • Status changed from new to needs_review

New commits:

​0240367trac #27010: save some calls to .vertices()

comment:2 Changed 6 months ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:3 Changed 5 months ago by embray

  • Milestone changed from sage-8.6 to sage-8.7

Retarging tickets optimistically to the next milestone. If you are responsible for this ticket (either its reporter or owner) and don't believe you are likely to complete this ticket before the next release (8.7) please retarget this ticket's milestone to sage-pending or sage-wishlist.

comment:4 Changed 5 months ago by vbraun

  • Branch changed from public/27010_graph to 0240367bef781fc219655b3bacd60ffd291eb595
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.