Opened 3 years ago

Closed 3 years ago

#27008 closed enhancement (fixed)

py3: avoid .vertices() in method apex_vertices

Reported by: dcoudert Owned by:
Priority: major Milestone: sage-8.7
Component: graph theory Keywords: py3, graph
Cc: tscrim, chapoton Merged in:
Authors: David Coudert Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 7538524 (Commits, GitHub, GitLab) Commit: 75385241794e7fc09eed30ead0e2e42bc04f7e3b
Dependencies: Stopgaps:

Status badges

Description

Calls to .vertices() were performed for small graphs and are not needed. We also avoid sorting edges when not required.

Change History (6)

comment:1 Changed 3 years ago by dcoudert

  • Branch set to public/27008_apex_vertices
  • Commit set to 9423e568e06dfd55b48044126fbbe8f3d759b109

New commits:

​9423e56avoid .vertices() in method apex_vertices

comment:2 Changed 3 years ago by git

  • Commit changed from 9423e568e06dfd55b48044126fbbe8f3d759b109 to 75385241794e7fc09eed30ead0e2e42bc04f7e3b

Branch pushed to git repo; I updated commit sha1. New commits:

​7538524trac #27008: fix a doctest

comment:3 Changed 3 years ago by dcoudert

  • Cc tscrim chapoton added
  • Status changed from new to needs_review

comment:4 Changed 3 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:5 Changed 3 years ago by embray

  • Milestone changed from sage-8.6 to sage-8.7

Retarging tickets optimistically to the next milestone. If you are responsible for this ticket (either its reporter or owner) and don't believe you are likely to complete this ticket before the next release (8.7) please retarget this ticket's milestone to sage-pending or sage-wishlist.

comment:6 Changed 3 years ago by vbraun

  • Branch changed from public/27008_apex_vertices to 75385241794e7fc09eed30ead0e2e42bc04f7e3b
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.