Opened 2 years ago
Closed 2 years ago
#27007 closed enhancement (fixed)
py3: avoid .vertices() in planarity.pyx
Reported by: | dcoudert | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-8.7 |
Component: | graph theory | Keywords: | py3, graph |
Cc: | tscrim, chapoton | Merged in: | |
Authors: | David Coudert | Reviewers: | Travis Scrimshaw |
Report Upstream: | N/A | Work issues: | |
Branch: | 536843f (Commits, GitHub, GitLab) | Commit: | 536843ff03c5d740b55c481ebf84636bb1b1ca53 |
Dependencies: | Stopgaps: |
Description (last modified by )
We change the mappings used in method is_planar
from file planarity.pyx
to avoid calls to .vertices()
.
The changes done here were inducing a doctest error in method genus
for
sage: cube.genus(circular=['01','10'], on_embedding=True)
As the documentation indicates that If ``circular`` is defined, ``on_embedding`` is not a valid option
, we now raise an error in this situation.
This patch fixes some doctests that where failing with py3 in methods
TutteGraph
ofsmallgraphs.py
apex_vertices
ofgraph.py
genus
ofgeneric_graph.py
Change History (5)
comment:1 Changed 2 years ago by
- Branch set to public/27007_planarity
- Commit set to 536843ff03c5d740b55c481ebf84636bb1b1ca53
comment:2 Changed 2 years ago by
- Cc tscrim chapoton added
- Description modified (diff)
- Status changed from new to needs_review
comment:3 Changed 2 years ago by
- Reviewers set to Travis Scrimshaw
- Status changed from needs_review to positive_review
LGTM.
comment:4 Changed 2 years ago by
- Milestone changed from sage-8.6 to sage-8.7
Retarging tickets optimistically to the next milestone. If you are responsible for this ticket (either its reporter or owner) and don't believe you are likely to complete this ticket before the next release (8.7) please retarget this ticket's milestone to sage-pending or sage-wishlist.
comment:5 Changed 2 years ago by
- Branch changed from public/27007_planarity to 536843ff03c5d740b55c481ebf84636bb1b1ca53
- Resolution set to fixed
- Status changed from positive_review to closed
New commits:
trac #27007: avoid .vertices() in planarity.pyx