Opened 3 years ago

Closed 2 years ago

#26991 closed enhancement (fixed)

Refactor function field code

Reported by: gh-BrentBaccala Owned by:
Priority: minor Milestone: sage-8.8
Component: algebra Keywords: function field
Cc: Merged in:
Authors: Brent Baccala Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 3f38d0e (Commits, GitHub, GitLab) Commit: 3f38d0ecb5b484c340eb319cd595cc4946a6c295
Dependencies: Stopgaps:

Status badges

Description (last modified by gh-BrentBaccala)

Several methods for elements in the new function field code (Trac #22982) can be profitably moved to the FunctionFieldElement superclass:

  • divisor, divisor_of_zeros, divisor_of_poles, zeros, and poles

Change History (10)

comment:1 Changed 3 years ago by gh-BrentBaccala

  • Branch set to public/26991
  • Commit set to 413aa01afc0684b0b2293ffd307ca167a3e25ab5
  • Dependencies changed from 22982 to u/klee/22982_stable

New commits:

d3b7833Add global function fields
f59d184Trac #26991: refactor divisor methods
d5d2ab0Trac #26991: refactor 'place' method into ideal super class
413aa01Trac #26991: refactor 'space_of_differentials' method in FunctionField

comment:2 Changed 3 years ago by gh-BrentBaccala

  • Dependencies changed from u/klee/22982_stable to #22982

comment:3 Changed 3 years ago by embray

  • Milestone changed from sage-8.6 to sage-8.7

Retarging tickets optimistically to the next milestone. If you are responsible for this ticket (either its reporter or owner) and don't believe you are likely to complete this ticket before the next release (8.7) please retarget this ticket's milestone to sage-pending or sage-wishlist.

comment:4 Changed 3 years ago by gh-BrentBaccala

  • Milestone changed from sage-8.7 to sage-pending

comment:5 Changed 2 years ago by git

  • Commit changed from 413aa01afc0684b0b2293ffd307ca167a3e25ab5 to a2b07a4f1804656ee1e6daae75e7f0092b0785d6

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

a2b07a4Trac #26991: refactor methods for function field divisors

comment:6 Changed 2 years ago by gh-BrentBaccala

  • Dependencies #22982 deleted
  • Milestone changed from sage-pending to sage-8.8
  • Status changed from new to needs_review

Most of the changes I proposed in the ticket description have already been done, but the element methods haven't been refactored, so that's all this ticket is now. It's important to get it done, though, because I have another ticket that depends on this refactorization.

I didn't make any changes to is_prime; even though I think it should throw NotImplementedError for classes where it isn't implemented. Maybe that's another ticket.

comment:7 Changed 2 years ago by git

  • Commit changed from a2b07a4f1804656ee1e6daae75e7f0092b0785d6 to 3f38d0ecb5b484c340eb319cd595cc4946a6c295

Branch pushed to git repo; I updated commit sha1. New commits:

3f38d0eMerge tag '8.8.beta7' into public/26991

comment:8 Changed 2 years ago by tscrim

  • Reviewers set to Travis Scrimshaw

Please update the ticket description to reflect what is done and set the author name. Once done, you can set a positive review.

comment:9 Changed 2 years ago by gh-BrentBaccala

  • Authors set to Brent Baccala
  • Description modified (diff)
  • Status changed from needs_review to positive_review

comment:10 Changed 2 years ago by vbraun

  • Branch changed from public/26991 to 3f38d0ecb5b484c340eb319cd595cc4946a6c295
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.