Opened 5 months ago

Last modified 7 weeks ago

#26991 needs_review enhancement

Refactor function field code

Reported by: gh-BrentBaccala Owned by:
Priority: minor Milestone: sage-8.8
Component: algebra Keywords: function field
Cc: Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: public/26991 (Commits) Commit: a2b07a4f1804656ee1e6daae75e7f0092b0785d6
Dependencies: Stopgaps:

Description

Several methods in the new function field code (Trac #22982) can be profitably moved to superclasses, including:

  • divisor, divisor_of_zeros, divisor_of_poles methods for both elements and ideals
  • place and is_prime methods in ideals

Change History (6)

comment:1 Changed 5 months ago by gh-BrentBaccala

  • Branch set to public/26991
  • Commit set to 413aa01afc0684b0b2293ffd307ca167a3e25ab5
  • Dependencies changed from 22982 to u/klee/22982_stable

New commits:

d3b7833Add global function fields
f59d184Trac #26991: refactor divisor methods
d5d2ab0Trac #26991: refactor 'place' method into ideal super class
413aa01Trac #26991: refactor 'space_of_differentials' method in FunctionField

comment:2 Changed 5 months ago by gh-BrentBaccala

  • Dependencies changed from u/klee/22982_stable to #22982

comment:3 Changed 4 months ago by embray

  • Milestone changed from sage-8.6 to sage-8.7

Retarging tickets optimistically to the next milestone. If you are responsible for this ticket (either its reporter or owner) and don't believe you are likely to complete this ticket before the next release (8.7) please retarget this ticket's milestone to sage-pending or sage-wishlist.

comment:4 Changed 4 months ago by gh-BrentBaccala

  • Milestone changed from sage-8.7 to sage-pending

comment:5 Changed 7 weeks ago by git

  • Commit changed from 413aa01afc0684b0b2293ffd307ca167a3e25ab5 to a2b07a4f1804656ee1e6daae75e7f0092b0785d6

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

a2b07a4Trac #26991: refactor methods for function field divisors

comment:6 Changed 7 weeks ago by gh-BrentBaccala

  • Dependencies #22982 deleted
  • Milestone changed from sage-pending to sage-8.8
  • Status changed from new to needs_review

Most of the changes I proposed in the ticket description have already been done, but the element methods haven't been refactored, so that's all this ticket is now. It's important to get it done, though, because I have another ticket that depends on this refactorization.

I didn't make any changes to is_prime; even though I think it should throw NotImplementedError for classes where it isn't implemented. Maybe that's another ticket.

Note: See TracTickets for help on using tickets.