Opened 3 years ago

Closed 3 years ago

#26988 closed enhancement (fixed)

py3: one tiny fix for isidentifier

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.7
Component: python3 Keywords:
Cc: tscrim Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 484ae66 (Commits, GitHub, GitLab) Commit: 484ae662839f983347fd606c98b40b3227c8017a
Dependencies: Stopgaps:

Status badges

Description

in symbolic/ring.pyx

This fixes the last failing doctest in calculus

Change History (5)

comment:1 Changed 3 years ago by chapoton

  • Branch set to u/chapoton/26988
  • Commit set to 484ae662839f983347fd606c98b40b3227c8017a
  • Status changed from new to needs_review

New commits:

​484ae66one fix for isidentifier

comment:2 Changed 3 years ago by chapoton

  • Cc tscrim added

bot is morally green, please review

comment:3 Changed 3 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:4 Changed 3 years ago by embray

  • Milestone changed from sage-8.6 to sage-8.7

Retarging tickets optimistically to the next milestone. If you are responsible for this ticket (either its reporter or owner) and don't believe you are likely to complete this ticket before the next release (8.7) please retarget this ticket's milestone to sage-pending or sage-wishlist.

comment:5 Changed 3 years ago by vbraun

  • Branch changed from u/chapoton/26988 to 484ae662839f983347fd606c98b40b3227c8017a
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.