Opened 4 years ago

Closed 4 years ago

#26980 closed defect (fixed)

sage-download-file script is not py3 compatible

Reported by: vbraun Owned by:
Priority: major Milestone: sage-8.6
Component: build Keywords:
Cc: Merged in:
Authors: Frédéric Chapoton Reviewers: Volker Braun
Report Upstream: N/A Work issues:
Branch: 255816a (Commits, GitHub, GitLab) Commit: 255816a514fd224753a6ffc7a1cbe671c60d55fe
Dependencies: Stopgaps:

Status badges

Description

Traceback (most recent call last):
  File "/var/lib/buildbot/slave/sage_git/build/build/bin/sage-download-file", line 28, in <module>
    run_safe()
  File "/var/lib/buildbot/slave/sage_git/build/build/bin/../sage_bootstrap/download/cmdline.py", line 119, in run_safe
    except StandardError as error:
NameError: name 'StandardError' is not defined

Change History (5)

comment:1 Changed 4 years ago by chapoton

  • Authors set to Frédéric Chapoton
  • Branch set to u/chapoton/26980
  • Commit set to ea4e0ecea8fb00dd84de258534f210e80ce3e9c5
  • Status changed from new to needs_review

fixed


New commits:

ea4e0ectrac 26980 fix script for python3

comment:2 Changed 4 years ago by vbraun

  • Branch changed from u/chapoton/26980 to u/vbraun/26980

comment:3 Changed 4 years ago by vbraun

  • Commit changed from ea4e0ecea8fb00dd84de258534f210e80ce3e9c5 to 255816a514fd224753a6ffc7a1cbe671c60d55fe
  • Reviewers set to Volker Braun

LGTM, thanks!

I've added some fixes to the testsuite (cd build && tox) which Eric broke with the sage-system-python addition.... Eventually this will be added as a buildstep to some buildbot.

Please set to positive review...


New commits:

255816aFix tox testsuite for sage_bootstrap

comment:4 Changed 4 years ago by chapoton

  • Status changed from needs_review to positive_review

ok, looks good enough

comment:5 Changed 4 years ago by vbraun

  • Branch changed from u/vbraun/26980 to 255816a514fd224753a6ffc7a1cbe671c60d55fe
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.