Opened 11 months ago

Closed 10 months ago

Last modified 6 months ago

#26969 closed enhancement (fixed)

Misc pip upgrades

Reported by: vbraun Owned by:
Priority: major Milestone: sage-8.7
Component: packages: standard Keywords: upgrade, pip
Cc: ​slelievre Merged in:
Authors: Volker Braun Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 0c414f8 (Commits) Commit:
Dependencies: Stopgaps:

Description (last modified by slelievre)

Follow upstream for pip packages that can be updated trivially...

Tarballs are already uploaded.

Updated packages:

  • alabaster 0.7.12 (from 0.7.10)
  • babel 2.6.0 (from 2.5.1)
  • backports_functools_lru_cache 1.5 (from 1.4)
  • bleach 3.0.2 (from 2.1.3)
  • certifi 2018.11.29 (from 2017.11.5)
  • cython 0.29.2 (from 0.29.1)
  • future 0.17.1 (from 0.16.0)
  • imagesize 1.1.0 (from 0.7.1.p0)
  • ipywidgets 7.4.2 (from 7.2.0)
  • itsdangerous 1.1.0 (from 0.24.p0)
  • jupyter_client 5.2.4 (from 5.2.3)
  • markupsafe 1.1.0 (from 1.0)
  • mistune 0.8.4 (from 0.8.3)
  • mpmath 1.1.0 (from 1.0.0)
  • nbconvert 5.4.0 (from 5.3.1)
  • notebook 5.7.4 (from 5.7.1)
  • packaging 18.0 (from 17.1)
  • pathlib2 2.3.3 (from 2.3.0)
  • pickleshare 0.7.5 (from 0.7.4)
  • pillow 5.3.0 (from 4.3.0.p0)
  • pip 18.1 (from 18.0)
  • pkgconfig 1.4.0 (from 1.2.2.p0)
  • prometheus_client 0.5.0 (from 0.3.1)
  • pygments 2.3.1 (from 2.2.0.p0)
  • pyparsing 2.3.0 (from 2.2.0)
  • pytz 2018.7 (from 2017.3)
  • pyzmq 17.1.2 (from 17.1.0)
  • scandir 1.9.0 (from 1.7)
  • scipy 1.2.0 (from 1.1.0)
  • setuptools 40.6.3 (from 40.0.0)
  • setuptools_scm 3.1.0 (from 1.15.6)
  • six 1.12.0 (from 1.11.0)
  • sphinxcontrib_websupport 1.1.0 (from 1.0.1)
  • subprocess32 3.5.3 (from 3.2.7.p0)
  • testpath 0.4.2 (from 0.3.1)
  • typing 3.6.6 (from 3.6.2)
  • werkzeug 0.14.1 (from 0.11.10.p0)
  • widgetsnbextension 3.4.2 (from 3.2.0)
  • zope_interface 4.6.0 (from 4.4.3)

Two package upgrades caused problems and are postponed:

  • ptyprocess
  • tornado

Change History (22)

comment:1 Changed 11 months ago by vbraun

  • Authors set to Volker Braun
  • Component changed from PLEASE CHANGE to packages: standard
  • Description modified (diff)
  • Type changed from PLEASE CHANGE to enhancement

comment:2 Changed 11 months ago by vbraun

  • Branch set to u/vbraun/misc_pip_upgrades

comment:3 Changed 11 months ago by vbraun

  • Cc ​slelievre added
  • Commit set to 23d134cce416db7d55c5b1a125958117c97bf76f
  • Description modified (diff)
  • Reviewers set to slelievre
  • Status changed from new to needs_review

New commits:

23d134cMiscellanious pip-style package updates

comment:4 Changed 11 months ago by chapoton

I have an error with tornado on a machine lacking ssl (see also patchbot report):

tornado-5.1.1] ****************************************************
[tornado-5.1.1] Uninstalling existing 'tornado'
[tornado-5.1.1] Installing tornado-5.1.1
[tornado-5.1.1] Traceback (most recent call last):
[tornado-5.1.1]   File "setup.py", line 18, in <module>
[tornado-5.1.1]     import ssl
[tornado-5.1.1]   File "/home/chapoton/sage/local/lib/python2.7/ssl.py", line 98, in <module>
[tornado-5.1.1]     import _ssl             # if we can't import it, let the error propagate
[tornado-5.1.1] ImportError: No module named _ssl
[tornado-5.1.1] Error: could not determine package name
[tornado-5.1.1] ********************************************************************************
[tornado-5.1.1] Error installing tornado-5.1.1
[tornado-5.1.1] ********************************************************************************
[tornado-5.1.1] 
[tornado-5.1.1] real	0m0.061s
[tornado-5.1.1] user	0m0.036s
[tornado-5.1.1] sys	0m0.002s
[tornado-5.1.1] ************************************************************************
[tornado-5.1.1] Error installing package tornado-5.1.1
[tornado-5.1.1] ************************************************************************

comment:5 Changed 11 months ago by chapoton

  • Status changed from needs_review to needs_work

on another machine, everything installs fine, but tornado is broken (maybe python3 only ?) and so breaks sagenb and jupyter notebook..

    from tornado.websocket import WebSocketHandler
  File "/home/chapoton/sage/local/lib/python2.7/site-packages/tornado/websocket.py", line 37, in <module>
    from tornado.queues import Queue
  File "/home/chapoton/sage/local/lib/python2.7/site-packages/tornado/queues.py", line 35, in <module>
    from tornado.locks import Event
  File "/home/chapoton/sage/local/lib/python2.7/site-packages/tornado/locks.py", line 18, in <module>
    from concurrent.futures import CancelledError
ImportError: No module named concurrent.futures
Last edited 11 months ago by chapoton (previous) (diff)

comment:6 Changed 11 months ago by slelievre

The tornado page on PyPI still lists Python 2.7:

  • Requires: Python >= 2.7, !=3.0.*, !=3.1.*, !=3.2.*, != 3.3.*

comment:7 Changed 11 months ago by chapoton

concurrent.futures is part of python3 standard library only. There is a backport to python 2.7 called futures

https://stackoverflow.com/questions/42377350/is-there-a-python-2-backport-for-the-concurrency-futures-package-from-python-3

comment:8 Changed 11 months ago by git

  • Commit changed from 23d134cce416db7d55c5b1a125958117c97bf76f to 4b8ed6c0fd6b98d12498cfb8cdc3495ce59edf86

Branch pushed to git repo; I updated commit sha1. New commits:

4b8ed6cDo not update tornado here

comment:9 Changed 11 months ago by vbraun

  • Status changed from needs_work to needs_review

OK lets not change tornado here


New commits:

4b8ed6cDo not update tornado here

comment:10 Changed 11 months ago by slelievre

Or we could upgrade to Tornado 4.5.3 here and leave Tornado 5.x for later (that's where the futures thing came in).

comment:11 Changed 11 months ago by vbraun

Or we could bikeshed forever and never merge the ticket...

comment:12 Changed 11 months ago by chapoton

Let us keep the tornado update for another ticket, for sure.

My patchbot failed to install "future".

comment:13 Changed 11 months ago by vbraun

Thats a race with copying files, it doesn't have anythnig to do with this ticket. I made #26990 for it.

comment:14 Changed 11 months ago by chapoton

  • Reviewers changed from slelievre to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok, then. Looks good to me.

comment:15 Changed 10 months ago by embray

  • Milestone changed from sage-8.6 to sage-8.7

Retarging tickets optimistically to the next milestone. If you are responsible for this ticket (either its reporter or owner) and don't believe you are likely to complete this ticket before the next release (8.7) please retarget this ticket's milestone to sage-pending or sage-wishlist.

comment:16 Changed 10 months ago by vbraun

  • Status changed from positive_review to needs_work

Breaks pexpect on OSX

comment:17 Changed 10 months ago by git

  • Commit changed from 4b8ed6c0fd6b98d12498cfb8cdc3495ce59edf86 to 0c414f817f78a7b40437a4c8c06f1ae5cb15ca2b

Branch pushed to git repo; I updated commit sha1. New commits:

0c414f8Revert ptyprocess update

comment:18 Changed 10 months ago by vbraun

  • Status changed from needs_work to positive_review

comment:19 Changed 10 months ago by slelievre

  • Description modified (diff)
  • Keywords upgrade pip added

Thanks!

comment:20 Changed 10 months ago by vbraun

  • Branch changed from u/vbraun/misc_pip_upgrades to 0c414f817f78a7b40437a4c8c06f1ae5cb15ca2b
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:21 Changed 6 months ago by chapoton

  • Commit 0c414f817f78a7b40437a4c8c06f1ae5cb15ca2b deleted

Time for another such ticket maybe ? I would like an upgrade of cython..

comment:22 Changed 6 months ago by chapoton

follow up at #27886

Note: See TracTickets for help on using tickets.