Opened 9 months ago

Closed 8 months ago

#26967 closed enhancement (fixed)

py3: some work on modular/modform_hecketriangle/

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.7
Component: python3 Keywords:
Cc: tscrim Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: e765ca6 (Commits) Commit: e765ca6502edf8b1a3dfdd0315019240d8dbd794
Dependencies: Stopgaps:

Description


Change History (8)

comment:1 Changed 9 months ago by chapoton

  • Branch set to u/chapoton/26967
  • Commit set to fc1bea721de116322d152d00e855fed8ec739363
  • Status changed from new to needs_review

New commits:

fc1bea7py3: some work on modular/modform_hecketriangle/

comment:2 Changed 9 months ago by git

  • Commit changed from fc1bea721de116322d152d00e855fed8ec739363 to 580be8fa4b10b5ad67c17355590e5c1b8c775c71

Branch pushed to git repo; I updated commit sha1. New commits:

580be8fharden one doctest in modform_hecketriangle

comment:3 Changed 9 months ago by git

  • Commit changed from 580be8fa4b10b5ad67c17355590e5c1b8c775c71 to e765ca6502edf8b1a3dfdd0315019240d8dbd794

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

e765ca6py3: some work on modular/modform_hecketriangle/

comment:4 Changed 9 months ago by chapoton

  • Cc tscrim added

green bot, please review.

I have some doubts on the use of SagePrettyPrinter instead of pprint.pformat. In particular, one is forced to import the necessary stuff inside the _repr_ to avoid importing IPython at startup. But Volker said once that one should avoid pprint.pformat, without telling what to do instead.

comment:5 Changed 9 months ago by tscrim

From #26628, it seems that SagePrettyPrinter is not working either. So I want to wait on this ticket until we can figure out #26628.

comment:6 Changed 9 months ago by chapoton

I would argue that here we will only use the pretty printer on a dict with keys all of the same nature (elements in the same ring), hence that should always be comparable. So it should be ok.

The phenomenon of impredictibility seen in #26628 comes from the comparison of letters and numbers.

Would you prefer to use pprint.pformat ?

Last edited 9 months ago by chapoton (previous) (diff)

comment:7 Changed 9 months ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

No, this will be fine.

comment:8 Changed 8 months ago by vbraun

  • Branch changed from u/chapoton/26967 to e765ca6502edf8b1a3dfdd0315019240d8dbd794
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.