Opened 3 years ago

Closed 3 years ago

#26965 closed defect (fixed)

sdh_install: fix installation of symlinks with invalid targets

Reported by: embray Owned by:
Priority: critical Milestone: sage-8.6
Component: build Keywords:
Cc: dimpase, mantepse Merged in:
Authors: Erik Bray Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: 5f49332 (Commits, GitHub, GitLab) Commit: 5f49332f10f0b869fe5f81a60c6ffcf609ee10d7
Dependencies: Stopgaps:

Status badges

Description (last modified by embray)

Using sdh_install to install a symlink whose target is not yet valid (e.g. is a path to a file that will be installed to $SAGE_LOCAL but is not yet installed) then it will fail, since the check test -e in sdh_install dereferences symlinks.

Marking critical since this fix is needed for #26856.

Change History (4)

comment:1 Changed 3 years ago by embray

  • Description modified (diff)

comment:2 Changed 3 years ago by embray

  • Status changed from new to needs_review

comment:3 Changed 3 years ago by dimpase

  • Reviewers set to Dima Pasechnik
  • Status changed from needs_review to positive_review

OK, this fixes the problem reported on #26856

comment:4 Changed 3 years ago by vbraun

  • Branch changed from u/embray/build/sdh-install-symlinks to 5f49332f10f0b869fe5f81a60c6ffcf609ee10d7
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.