Opened 2 years ago

Closed 2 years ago

#26947 closed defect (fixed)

UnionOfIntervals.__contains__ doctest tests str

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-8.6
Component: coercion Keywords:
Cc: cremona Merged in:
Authors: Jeroen Demeyer Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 6a8b25b (Commits, GitHub, GitLab) Commit: 6a8b25b9462acd4a0b609351d66402888549d527
Dependencies: Stopgaps:

Status badges

Description

It is documented that the input of __contains__ should be a real number, yet there is this doctest:

            sage: 'a' in A
            False

This will break after #22029.

Since this test is meaningless, it should just be removed.

Change History (4)

comment:1 Changed 2 years ago by jdemeyer

  • Branch set to u/jdemeyer/unionofintervals___contains___doctest_tests_str

comment:2 Changed 2 years ago by jdemeyer

  • Authors set to Jeroen Demeyer
  • Commit set to 6a8b25b9462acd4a0b609351d66402888549d527
  • Status changed from new to needs_review

New commits:

6a8b25bRemove UnionOfIntervals.__contains__ test with str input

comment:3 Changed 2 years ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok

comment:4 Changed 2 years ago by vbraun

  • Branch changed from u/jdemeyer/unionofintervals___contains___doctest_tests_str to 6a8b25b9462acd4a0b609351d66402888549d527
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.