Opened 4 years ago

Closed 4 years ago

#26935 closed defect (fixed)

AbstractLanguage should work with uncomparable alphabet

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-8.6
Component: combinatorics Keywords:
Cc: vdelecroix Merged in:
Authors: Jeroen Demeyer Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: d0ad378 (Commits, GitHub, GitLab) Commit: d0ad378c279b0628b84941ac1444c16b198cd7f4
Dependencies: Stopgaps:

Status badges

Description

This code tries to compare various elements of the alphabet which might break in Python 3 or after #22029 is applied:

        if (alphabet.cardinality() == Infinity or
            (alphabet.cardinality() < 36 and
             all(alphabet.unrank(i) > alphabet.unrank(j)
                 for i in range(min(36, alphabet.cardinality()))
                 for j in range(i)))):

Change History (4)

comment:1 Changed 4 years ago by jdemeyer

  • Branch set to u/jdemeyer/abstractlanguage_should_work_with_uncomparable_alphabet

comment:2 Changed 4 years ago by jdemeyer

  • Authors set to Jeroen Demeyer
  • Commit set to d0ad378c279b0628b84941ac1444c16b198cd7f4
  • Status changed from new to needs_review

New commits:

d0ad378AbstractLanguage should work with uncomparable alphabet

comment:3 Changed 4 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:4 Changed 4 years ago by vbraun

  • Branch changed from u/jdemeyer/abstractlanguage_should_work_with_uncomparable_alphabet to d0ad378c279b0628b84941ac1444c16b198cd7f4
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.