Opened 5 months ago

Closed 5 months ago

#26934 closed defect (fixed)

Remove pointless comparison doctests in valuations

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-8.6
Component: python3 Keywords:
Cc: saraedum Merged in:
Authors: Jeroen Demeyer Reviewers: Julian Rüth
Report Upstream: N/A Work issues:
Branch: d7ece06 (Commits) Commit: d7ece0605d390062cf625de4c54608cd05bfc8fa
Dependencies: Stopgaps:

Description (last modified by jdemeyer)

These doctests specifically try to compare uncomparable valuations, which is going to be an error after #22029.

Change History (5)

comment:1 Changed 5 months ago by jdemeyer

  • Branch set to u/jdemeyer/remove_pointless_comparison_doctests_in_valuations

comment:2 Changed 5 months ago by jdemeyer

  • Commit set to d7ece0605d390062cf625de4c54608cd05bfc8fa
  • Description modified (diff)
  • Status changed from new to needs_review

New commits:

​d7ece06Remove pointless comparison doctests in valuations

comment:3 Changed 5 months ago by jdemeyer

  • Cc saraedum added

comment:4 Changed 5 months ago by saraedum

  • Reviewers set to Julian Rüth
  • Status changed from needs_review to positive_review

The clarification is not necessary anymore once #22029 has been merged.

comment:5 Changed 5 months ago by vbraun

  • Branch changed from u/jdemeyer/remove_pointless_comparison_doctests_in_valuations to d7ece0605d390062cf625de4c54608cd05bfc8fa
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.