Opened 2 months ago

Closed 8 weeks ago

#26918 closed enhancement (fixed)

py3: care for Schnyder woods

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.6
Component: python3 Keywords:
Cc: tscrim Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 43e5f64 (Commits) Commit: 43e5f643e62b4a05064f240bdc7f5131059bd51b
Dependencies: Stopgaps:

Description

by not mixing integers and letters as vertices of graphs there

Change History (7)

comment:1 Changed 2 months ago by chapoton

  • Branch set to u/chapoton/26918
  • Commit set to 87cdeb7bf45ef8892a3f16308d0d83ac4323037c
  • Status changed from new to needs_review

New commits:

87cdeb7py3: caring for Schnyder woods

comment:2 Changed 2 months ago by chapoton

  • Status changed from needs_review to needs_work

comment:3 Changed 2 months ago by git

  • Commit changed from 87cdeb7bf45ef8892a3f16308d0d83ac4323037c to 0ff511b5573c40108081adb74534f6cfb5eeb308

Branch pushed to git repo; I updated commit sha1. New commits:

0ff511btrac 26918 fix wrong relabelling of embeddings

comment:4 Changed 2 months ago by git

  • Commit changed from 0ff511b5573c40108081adb74534f6cfb5eeb308 to 43e5f643e62b4a05064f240bdc7f5131059bd51b

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

43e5f64trac 26918 fix wrong relabelling of embeddings

comment:5 Changed 2 months ago by chapoton

  • Cc tscrim added
  • Status changed from needs_work to needs_review

green bot, please review

comment:6 Changed 2 months ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

While I do not strictly like sweeping the issue under the rug, we should make some progress here as graphs still needs a lot of work.

comment:7 Changed 8 weeks ago by vbraun

  • Branch changed from u/chapoton/26918 to 43e5f643e62b4a05064f240bdc7f5131059bd51b
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.