Opened 9 months ago

Closed 9 months ago

#26913 closed enhancement (fixed)

py3: fix sorting of isogeny classes of elliptic curves

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.6
Component: python3 Keywords:
Cc: tscrim, cremona Merged in:
Authors: Frédéric Chapoton Reviewers: John Cremona
Report Upstream: N/A Work issues:
Branch: 25a1760 (Commits) Commit: 25a1760ed896090addc6651593798fd5aa87a232
Dependencies: Stopgaps:

Description (last modified by chapoton)

because this currently uses the richcmp of elliptic curves coming from the classe WithEqualityById?, that only handles == and !=

plus a small-scale cleanup of the modified file

Change History (6)

comment:1 Changed 9 months ago by chapoton

  • Branch set to u/chapoton/26913
  • Commit set to 25a1760ed896090addc6651593798fd5aa87a232
  • Description modified (diff)
  • Status changed from new to needs_review

New commits:

​25a1760py3: fix sorting of isogeny classes of elliptic curves

comment:2 Changed 9 months ago by cremona

You have CC'd me as author of most of the code in this file, but I don't really understand this richcmp stuff so will keep quiet. If no test fail then I'm fairly sure it will be OK for me. There certainly are difficult problems surrounding how the curves in each isogeny class can be sorted for labelling purposes for the LMFDB but that is not affected by this code change.

comment:3 Changed 9 months ago by chapoton

Thanks, John. This is certainly a harmless change, but I wanted to keep you informed.

comment:4 Changed 9 months ago by chapoton

green bot, ready for review

comment:5 Changed 9 months ago by cremona

  • Reviewers set to John Cremona
  • Status changed from needs_review to positive_review

comment:6 Changed 9 months ago by vbraun

  • Branch changed from u/chapoton/26913 to 25a1760ed896090addc6651593798fd5aa87a232
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.