Opened 5 months ago

Closed 5 months ago

#26909 closed enhancement (fixed)

py3: cleanup the groebner_fan file

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.6
Component: python3 Keywords:
Cc: tscrim Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 0906889 (Commits) Commit: 0906889cc243bc34ace7a404b78d39c2ede8a673
Dependencies: Stopgaps:

Description

also including some pep and code cleanup

Change History (4)

comment:1 Changed 5 months ago by chapoton

  • Branch set to u/chapoton/26909
  • Commit set to 0906889cc243bc34ace7a404b78d39c2ede8a673
  • Status changed from new to needs_review

New commits:

​0906889py3 and pep cleanup for groebner_fan.py

comment:2 Changed 5 months ago by chapoton

  • Cc tscrim added

green bot, please review

comment:3 Changed 5 months ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:4 Changed 5 months ago by vbraun

  • Branch changed from u/chapoton/26909 to 0906889cc243bc34ace7a404b78d39c2ede8a673
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.