#26882 closed enhancement (fixed)
Remove useless point doubling in Miller alg
Reported by: | gh-qberthet | Owned by: | |
---|---|---|---|
Priority: | trivial | Milestone: | sage-8.6 |
Component: | elliptic curves | Keywords: | |
Cc: | Merged in: | ||
Authors: | Quentin Berthet | Reviewers: | Jeroen Demeyer |
Report Upstream: | N/A | Work issues: | |
Branch: | f1f01cb (Commits, GitHub, GitLab) | Commit: | f1f01cbc8ef814713907a21480d79c3a0f6a6147 |
Dependencies: | Stopgaps: |
Description (last modified by )
Small and trivial optimization in Miller algorithm computation:
The first point doubling (ell_point.py#L1515) seems useless as it is done in the beginning of the loop (ell_point.py#L1519), value from the first operation is not used in between.
In case the loop is not executed (unlikely), the S variable is not used neither.
This save a ec point doubling by call, which is not that much, but still good to take.
Change History (7)
comment:1 Changed 4 years ago by
- Branch set to u/gh-qberthet/remove_useless_point_doubling_in_miller_alg
comment:2 Changed 4 years ago by
- Branch changed from u/gh-qberthet/remove_useless_point_doubling_in_miller_alg to u/gh-qberthet/remove_useless_point_doubling_in_miller_algorithm
comment:3 Changed 4 years ago by
- Commit set to f1f01cbc8ef814713907a21480d79c3a0f6a6147
comment:4 Changed 4 years ago by
- Component changed from PLEASE CHANGE to elliptic curves
- Description modified (diff)
- Priority changed from major to trivial
- Status changed from new to needs_review
- Type changed from PLEASE CHANGE to enhancement
comment:5 Changed 4 years ago by
- Reviewers set to Jeroen Demeyer
- Status changed from needs_review to positive_review
comment:6 Changed 4 years ago by
- Branch changed from u/gh-qberthet/remove_useless_point_doubling_in_miller_algorithm to f1f01cbc8ef814713907a21480d79c3a0f6a6147
- Resolution set to fixed
- Status changed from positive_review to closed
comment:7 Changed 4 years ago by
- Milestone changed from sage-8.5 to sage-8.6
This tickets were closed as fixed after the Sage 8.5 release.
Note: See
TracTickets for help on using
tickets.
Branch pushed to git repo; I updated commit sha1. New commits:
Remove useless point doubling in Miller algorithm