Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#26879 closed enhancement (fixed)

Deprecate _element_constructor_ being an unbound method

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-8.6
Component: coercion Keywords:
Cc: tscrim Merged in:
Authors: Jeroen Demeyer Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 4de2aba (Commits, GitHub, GitLab) Commit:
Dependencies: #26878 Stopgaps:

Status badges

Description (last modified by jdemeyer)

The _element_constructor machinery in Parent has support both for P._element_constructor_ being a bound and an unbound method. However, after #26878, the only case that occurs is bound methods. So we deprecate support for unbound methods.

Practically speaking, this means deprecating DefaultConvertMap (only when used directly, not when subclassed) which is the class implementing conversion using an unbound _element_constructor_ and deprecating the _element_init_pass_parent=True case in IdentityMorphism.

Change History (10)

comment:1 Changed 4 years ago by jdemeyer

  • Description modified (diff)

comment:2 Changed 4 years ago by jdemeyer

  • Summary changed from Deprecate _element_constructor_ which is unbound method to Deprecate _element_constructor_ being an unbound method

comment:3 Changed 4 years ago by jdemeyer

  • Branch set to u/jdemeyer/ticket/26879

comment:4 Changed 4 years ago by jdemeyer

  • Commit set to a42b07274daae91cedea9e35ddcdb8a933ae7ef7
  • Status changed from new to needs_review

New commits:

2431770Remove deprecated code regarding parent initialization
995ca87Use getattr_from_other_class to create a bound method
a42b072Deprecate DefaultConvertMap base class

comment:5 Changed 4 years ago by jdemeyer

  • Description modified (diff)

comment:6 Changed 4 years ago by git

  • Commit changed from a42b07274daae91cedea9e35ddcdb8a933ae7ef7 to 4de2abafc40d869b102b768ae5f390ad4c3ad579

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

4de2abaDeprecate _element_init_pass_parent=True

comment:7 Changed 4 years ago by jdemeyer

  • Cc tscrim added

comment:8 Changed 4 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:9 Changed 4 years ago by vbraun

  • Branch changed from u/jdemeyer/ticket/26879 to 4de2abafc40d869b102b768ae5f390ad4c3ad579
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:10 Changed 4 years ago by embray

  • Commit 4de2abafc40d869b102b768ae5f390ad4c3ad579 deleted
  • Milestone changed from sage-8.5 to sage-8.6
Note: See TracTickets for help on using tickets.