Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#26878 closed enhancement (fixed)

KleshchevPartitions: ensure that _element_constructor_ is a bound method

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-8.6
Component: coercion Keywords:
Cc: tscrim Merged in:
Authors: Jeroen Demeyer Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 995ca87 (Commits, GitHub, GitLab) Commit: 995ca87240111eadeffafce16c6bb42107c35bc4
Dependencies: #26873 Stopgaps:

Status badges

Description

The _element_constructor machinery in Parent has support both for P._element_constructor_ being a bound and an unbound method. However, there is exactly one case where an unbound method occurs and that is for KleshchevPartitions.

It would be good to simplify the _element_constructor handling to always assume a bound method, but then KleshchevPartitions must be fixed.

Change History (7)

comment:1 Changed 4 years ago by jdemeyer

  • Branch set to u/jdemeyer/kleshchevpartitions__ensure_that__element_constructor__is_a_bound_method

comment:2 Changed 4 years ago by git

  • Commit set to 995ca87240111eadeffafce16c6bb42107c35bc4

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

2431770Remove deprecated code regarding parent initialization
995ca87Use getattr_from_other_class to create a bound method

comment:3 Changed 4 years ago by jdemeyer

  • Dependencies set to #26873
  • Status changed from new to needs_review

New commits:

2431770Remove deprecated code regarding parent initialization
995ca87Use getattr_from_other_class to create a bound method

comment:4 Changed 4 years ago by tscrim

  • Reviewers set to Travis Scrimshaw

Makes sense and LGTM. If a patchbot comes around green, then positive review.

comment:5 Changed 4 years ago by chapoton

  • Status changed from needs_review to positive_review

comment:6 Changed 4 years ago by vbraun

  • Branch changed from u/jdemeyer/kleshchevpartitions__ensure_that__element_constructor__is_a_bound_method to 995ca87240111eadeffafce16c6bb42107c35bc4
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:7 Changed 4 years ago by embray

  • Milestone changed from sage-8.5 to sage-8.6

This tickets were closed as fixed after the Sage 8.5 release.

Note: See TracTickets for help on using tickets.