#26875 closed enhancement (fixed)
new method is_integral for elements of universal cyclotomic field
Reported by: | chapoton | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-8.6 |
Component: | algebra | Keywords: | |
Cc: | stumpc5, tscrim | Merged in: | |
Authors: | Frédéric Chapoton | Reviewers: | Christian Stump |
Report Upstream: | N/A | Work issues: | |
Branch: | b7f0b12 (Commits, GitHub, GitLab) | Commit: | b7f0b12d461b3ae4c8322275279b7c7e4e58f544 |
Dependencies: | Stopgaps: |
Description
as this can be useful
Change History (8)
comment:1 Changed 3 years ago by
- Branch set to u/chapoton/26875
- Commit set to b7f0b12d461b3ae4c8322275279b7c7e4e58f544
- Status changed from new to needs_review
comment:2 Changed 3 years ago by
green bot, please review
comment:3 Changed 3 years ago by
- Reviewers set to Christian Stump
- Status changed from needs_review to positive_review
comment:4 Changed 3 years ago by
What was the point of all the changes
- k = self._obj.Conductor().sage() + k = ZZ(self._obj.Conductor())
comment:5 follow-up: ↓ 6 Changed 3 years ago by
For speed. The latter is slightly faster than the former.
comment:6 in reply to: ↑ 5 Changed 3 years ago by
Replying to chapoton:
For speed. The latter is slightly faster than the former.
Then why not make the former faster?
comment:7 Changed 3 years ago by
- Branch changed from u/chapoton/26875 to b7f0b12d461b3ae4c8322275279b7c7e4e58f544
- Resolution set to fixed
- Status changed from positive_review to closed
comment:8 Changed 3 years ago by
- Milestone changed from sage-8.5 to sage-8.6
This tickets were closed as fixed after the Sage 8.5 release.
Note: See
TracTickets for help on using
tickets.
New commits:
new method "is_integral" for elements of universal cyclotomic field