Opened 10 months ago

Closed 10 months ago

Last modified 10 months ago

#26873 closed enhancement (fixed)

Remove deprecations in Parent.__init__

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-8.6
Component: misc Keywords:
Cc: chapoton Merged in:
Authors: Jeroen Demeyer Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 2431770 (Commits) Commit: 24317703856a197ccdb606f86a965c8ca9a76082
Dependencies: Stopgaps:

Description (last modified by jdemeyer)

Remove code deprecated in #24109, #23917.

Also make it an error to call _init_category_ with a non-Category and use type(self) instead of self.__class__.

Change History (11)

comment:1 Changed 10 months ago by jdemeyer

  • Summary changed from Remove deprecations in parent to Remove deprecations in Parent.__init__

comment:2 Changed 10 months ago by jdemeyer

  • Description modified (diff)

comment:3 Changed 10 months ago by jdemeyer

  • Branch set to u/jdemeyer/remove_deprecations_in_parent

comment:4 Changed 10 months ago by jdemeyer

  • Commit set to 8add14ff10642160c6adb5b7139b73814420ac0d
  • Status changed from new to needs_review

New commits:

​8add14fRemove deprecated code regarding parent initialization

comment:5 Changed 10 months ago by jdemeyer

  • Description modified (diff)

comment:6 Changed 10 months ago by git

  • Commit changed from 8add14ff10642160c6adb5b7139b73814420ac0d to e51142df7519944ebf81ebded998468ae6386d1e

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​e51142dRemove deprecated code regarding parent initialization

comment:7 Changed 10 months ago by git

  • Commit changed from e51142df7519944ebf81ebded998468ae6386d1e to 24317703856a197ccdb606f86a965c8ca9a76082

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​2431770Remove deprecated code regarding parent initialization

comment:8 Changed 10 months ago by jdemeyer

  • Description modified (diff)

comment:9 Changed 10 months ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok, looks good

comment:10 Changed 10 months ago by vbraun

  • Branch changed from u/jdemeyer/remove_deprecations_in_parent to 24317703856a197ccdb606f86a965c8ca9a76082
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:11 Changed 10 months ago by embray

  • Milestone changed from sage-8.5 to sage-8.6

This tickets were closed as fixed after the Sage 8.5 release.

Note: See TracTickets for help on using tickets.