Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#26871 closed enhancement (fixed)

py3: fix doctests in digraph_generators.py

Reported by: dcoudert Owned by:
Priority: major Milestone: sage-8.6
Component: graph theory Keywords: py3, graph
Cc: tscrim, chapoton Merged in:
Authors: David Coudert Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 2c066f6 (Commits, GitHub, GitLab) Commit: 2c066f6a39fb0daaeb09d42896d1c48c24589028
Dependencies: Stopgaps:

Status badges

Description

  • fix method tournaments_nauty using to bytes_to_str
  • fix doctest in method RandomDirectedGNC by avoiding to print the list of edges and testing that the digraph is acyclic instead
  • fix method RandomDirectedGNR that was calling networkx.random_gnc instead of networkx.random_gnr... and then fix the doctests by avoiding to print the list of edges and testing instead that the digraph is acyclic and is a tree

Change History (4)

comment:1 Changed 3 years ago by dcoudert

  • Branch set to public/26871_digraph_generators
  • Commit set to 2c066f6a39fb0daaeb09d42896d1c48c24589028
  • Status changed from new to needs_review

New commits:

​2c066f6trac #26871: fix digraph generators

comment:2 Changed 3 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:3 Changed 3 years ago by vbraun

  • Branch changed from public/26871_digraph_generators to 2c066f6a39fb0daaeb09d42896d1c48c24589028
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:4 Changed 3 years ago by embray

  • Milestone changed from sage-8.5 to sage-8.6

This tickets were closed as fixed after the Sage 8.5 release.

Note: See TracTickets for help on using tickets.