Opened 14 months ago

Last modified 13 months ago

#26869 closed enhancement

py3: improve is_aperiodic to fix doctests — at Version 1

Reported by: dcoudert Owned by:
Priority: major Milestone: sage-8.6
Component: graph theory Keywords: py3, graph
Cc: tscrim, chapoton, mercatp Merged in:
Authors: David Coudert Reviewers:
Report Upstream: N/A Work issues:
Branch: public/26869_is_periodic (Commits) Commit: 207fe9eb69e52ce710e523236351af58387ea525
Dependencies: Stopgaps:

Description (last modified by dcoudert)

The current implementation of is_aperiodic uses networkx and it yields an error in Python3 (due to a deprecation warning).

As we have method period that computes the period of a digraph, it suffices to check whether the period is 1 or not. This way, we don't pay the conversion to networkx anymore, and we avoid the failing doctests in and in static_sparse_graph.pyx (calls is_aperiodic).

Change History (1)

comment:1 Changed 14 months ago by dcoudert

  • Branch set to public/26869_is_periodic
  • Commit set to 207fe9eb69e52ce710e523236351af58387ea525
  • Description modified (diff)
  • Status changed from new to needs_review

New commits:

207fe9etrac #26869: fix is_aperiodic
Note: See TracTickets for help on using tickets.