Changes between Initial Version and Version 1 of Ticket #26869


Ignore:
Timestamp:
12/11/18 01:37:06 (7 months ago)
Author:
dcoudert
Comment:

New commits:

207fe9etrac #26869: fix is_aperiodic

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #26869

    • Property Status changed from new to needs_review
    • Property Commit changed from to 207fe9eb69e52ce710e523236351af58387ea525
    • Property Branch changed from to public/26869_is_periodic
  • Ticket #26869 – Description

    initial v1  
    1 The current implementation of `is_aperiodic` uses networkx and it yields an error in Python3 (certainly not the good version of networkx, could be fixed with a new version).
     1The current implementation of `is_aperiodic` uses networkx and it yields an error in Python3 (due to a deprecation warning).
    22
    3 As we have method `period` that computes the period of a digraph, it suffices to check whether the period is 1 or not. This way, we don't pay the conversion to networkx anymore, and we fix some doctests in `digraph.py` and in `static_sparse_graph.pyx` (calls `is_aperiodic`).
     3As we have method `period` that computes the period of a digraph, it suffices to check whether the period is 1 or not. This way, we don't pay the conversion to networkx anymore, and we avoid the failing doctests in `digraph.py` and in `static_sparse_graph.pyx` (calls `is_aperiodic`).