Opened 4 years ago

Closed 4 years ago

#26864 closed defect (fixed)

Indentation error in Number Field

Reported by: Mckenzie West Owned by:
Priority: major Milestone: sage-8.7
Component: number fields Keywords:
Cc: Merged in:
Authors: Mckenzie West Reviewers: Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: 61bb326 (Commits, GitHub, GitLab) Commit: 61bb326b6f639085d3d7b222e802487349610618
Dependencies: Stopgaps:

Status badges

Description

Followup to a comment in #22148 to fix the indentation in numberfield.py within the solve_S_unit_equation function.

Change History (13)

comment:1 Changed 4 years ago by Mckenzie West

Branch: u/mwest/indentation_error_in_number_field

comment:2 Changed 4 years ago by Mckenzie West

Commit: f96362e479297bd812397164b82f6a48d7d8a9f7
Status: newneeds_review

New commits:

f96362eFixed indentation of documentation in solve_S_unit_equation

comment:3 Changed 4 years ago by Marc Mezzarobba

Is the change "verbose" → "proof" intentional?

comment:4 Changed 4 years ago by Mckenzie West

The change in documentation was done to match the actual function.

comment:5 in reply to:  4 ; Changed 4 years ago by Marc Mezzarobba

Replying to mwest:

The change in documentation was done to match the actual function.

Shouldn't the description be changed as well, then?

comment:6 in reply to:  5 Changed 4 years ago by Mckenzie West

Replying to mmezzarobba:

Replying to mwest:

The change in documentation was done to match the actual function.

Shouldn't the description be changed as well, then?

I am not sure why it was proof instead of verbose, I have updated it to "verbose" so that it matches the functions in S_unit_solver.py.

comment:7 Changed 4 years ago by Jeroen Demeyer

Status: needs_reviewneeds_work

The change verbose -> proof was correct, but also the description of the proof parameter should be fixed.

comment:8 Changed 4 years ago by git

Commit: f96362e479297bd812397164b82f6a48d7d8a9f761bb326b6f639085d3d7b222e802487349610618

Branch pushed to git repo; I updated commit sha1. New commits:

32bda6dChanging proof -> verbose to match code in S_unit_solver.py
61bb326Changed documentation to match proof parameter

comment:9 Changed 4 years ago by Mckenzie West

Status: needs_workneeds_review

Ok, I now understand what is happening, everything is fixed.

comment:10 Changed 4 years ago by Jeroen Demeyer

Authors: Mckenzie West

comment:11 Changed 4 years ago by Jeroen Demeyer

Reviewers: Jeroen Demeyer
Status: needs_reviewpositive_review

comment:12 Changed 4 years ago by Frédéric Chapoton

Milestone: sage-8.5sage-8.7

comment:13 Changed 4 years ago by Volker Braun

Branch: u/mwest/indentation_error_in_number_field61bb326b6f639085d3d7b222e802487349610618
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.