Opened 4 years ago
Closed 3 years ago
#26862 closed enhancement (invalid)
Few unused variable
Reported by: | jmantysalo | Owned by: | |
---|---|---|---|
Priority: | trivial | Milestone: | sage-duplicate/invalid/wontfix |
Component: | combinatorics | Keywords: | |
Cc: | Merged in: | ||
Authors: | Jori Mäntysalo | Reviewers: | |
Report Upstream: | N/A | Work issues: | |
Branch: | public/ticket/26862 (Commits, GitHub, GitLab) | Commit: | 56fefeccd04fb1175eeb5dc2d51233d95d8bb981 |
Dependencies: | Stopgaps: |
Description
Just tested pyflakes.
Change History (9)
comment:1 Changed 4 years ago by
- Branch set to u/jmantysalo/unused-variables
comment:2 Changed 4 years ago by
- Commit set to fe6d162ab91f58e379a18feb966698ab3af1d0e5
- Status changed from new to needs_review
comment:3 follow-up: ↓ 4 Changed 4 years ago by
will conflict with #26805
comment:4 in reply to: ↑ 3 Changed 4 years ago by
- Status changed from needs_review to needs_work
comment:5 Changed 3 years ago by
- Branch changed from u/jmantysalo/unused-variables to public/ticket/26862
- Commit changed from fe6d162ab91f58e379a18feb966698ab3af1d0e5 to 56fefeccd04fb1175eeb5dc2d51233d95d8bb981
- Status changed from needs_work to needs_review
New commits:
56fefec | Merge branch 'u/jmantysalo/unused-variables' in 8.7.b4
|
comment:6 follow-up: ↓ 8 Changed 3 years ago by
Hmm, the diff is now almost empty, so that I would suggest to just close as invalid...
comment:7 Changed 3 years ago by
- Milestone changed from sage-8.5 to sage-duplicate/invalid/wontfix
comment:8 in reply to: ↑ 6 Changed 3 years ago by
- Status changed from needs_review to positive_review
Replying to chapoton:
Hmm, the diff is now almost empty, so that I would suggest to just close as invalid...
True.
comment:9 Changed 3 years ago by
- Resolution set to invalid
- Status changed from positive_review to closed
Presuming these are all correctly reviewed as either duplicate, invalid, or wontfix.
Note: See
TracTickets for help on using
tickets.
New commits:
Unused variables.