Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#26861 closed defect (fixed)

Dimension certificate of a chain poset

Reported by: jmantysalo Owned by:
Priority: minor Milestone: sage-8.6
Component: combinatorics Keywords:
Cc: tscrim Merged in:
Authors: Jori Mäntysalo Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 9796d62 (Commits, GitHub, GitLab) Commit: 9796d624cf3c13289dcb5122c3a4bf94d2b9d5f2
Dependencies: Stopgaps:

Status badges

Description

posets.ChainPoset(3).dimension(certificate=True)[1] returns [0, 1, 2], should be [[0, 1, 2]].

Change History (9)

comment:1 Changed 3 years ago by jmantysalo

  • Branch set to u/jmantysalo/dimension_certificate_of_a_chain_poset

comment:2 Changed 3 years ago by jmantysalo

  • Cc tscrim added
  • Commit set to 9a29058c95eeeb35a5ef9409364ba1b24cf95418
  • Status changed from new to needs_review

Oneliner for review.

New commits:

​9a29058Fix certificate for chain.

comment:3 follow-up: Changed 3 years ago by chapoton

please add a doctest

comment:4 Changed 3 years ago by git

  • Commit changed from 9a29058c95eeeb35a5ef9409364ba1b24cf95418 to 30837fd4cf8cdbd19bd7cbf841ef40cb9e84bec5

Branch pushed to git repo; I updated commit sha1. New commits:

​30837fdAdd test.

comment:5 in reply to: ↑ 3 Changed 3 years ago by jmantysalo

Replying to chapoton:

please add a doctest

Added.

comment:6 Changed 3 years ago by git

  • Commit changed from 30837fd4cf8cdbd19bd7cbf841ef40cb9e84bec5 to 9796d624cf3c13289dcb5122c3a4bf94d2b9d5f2

Branch pushed to git repo; I updated commit sha1. New commits:

​9796d62Wrong trac number.

comment:7 Changed 3 years ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok

comment:8 Changed 3 years ago by vbraun

  • Branch changed from u/jmantysalo/dimension_certificate_of_a_chain_poset to 9796d624cf3c13289dcb5122c3a4bf94d2b9d5f2
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:9 Changed 3 years ago by embray

  • Milestone changed from sage-8.5 to sage-8.6

This tickets were closed as fixed after the Sage 8.5 release.

Note: See TracTickets for help on using tickets.