Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#26858 closed enhancement (fixed)

lazy import everything in finance

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.6
Component: refactoring Keywords:
Cc: Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 20ba3e7 (Commits, GitHub, GitLab) Commit: 20ba3e72d02d38f06ba9c93bef3a0ea6dd8d8d17
Dependencies: Stopgaps:

Status badges

Description


Change History (8)

comment:1 Changed 4 years ago by chapoton

  • Branch set to u/chapoton/26858
  • Commit set to 9ba1a9aa3d444e2d8474d50d590ddc759555e739
  • Status changed from new to needs_review

New commits:

9ba1a9alazy import everything in finance

comment:2 Changed 4 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM (assuming green bot).

comment:3 Changed 4 years ago by chapoton

  • Status changed from positive_review to needs_work

needs some fix for the failing doctests

comment:4 Changed 4 years ago by git

  • Commit changed from 9ba1a9aa3d444e2d8474d50d590ddc759555e739 to 20ba3e72d02d38f06ba9c93bef3a0ea6dd8d8d17

Branch pushed to git repo; I updated commit sha1. New commits:

20ba3e7trac 26858 fix doctests in stock.py

comment:5 Changed 4 years ago by chapoton

  • Status changed from needs_work to needs_review

all tests now pass in finance/

comment:6 Changed 4 years ago by tscrim

  • Status changed from needs_review to positive_review

comment:7 Changed 4 years ago by vbraun

  • Branch changed from u/chapoton/26858 to 20ba3e72d02d38f06ba9c93bef3a0ea6dd8d8d17
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:8 Changed 4 years ago by embray

  • Milestone changed from sage-8.5 to sage-8.6

This tickets were closed as fixed after the Sage 8.5 release.

Note: See TracTickets for help on using tickets.