Opened 6 months ago

Closed 6 months ago

Last modified 6 months ago

#26847 closed defect (fixed)

fix certificate of is_subdirectly_reducible

Reported by: mantepse Owned by:
Priority: major Milestone: sage-8.6
Component: combinatorics Keywords:
Cc: jmantysalo Merged in:
Authors: Martin Rubey Reviewers: Jori Mäntysalo
Report Upstream: N/A Work issues:
Branch: 416b083 (Commits) Commit: 416b0835bd1e1eb5c2cdc7b0d55700bbf420757d
Dependencies: Stopgaps:

Description (last modified by jmantysalo)

hex = LatticePoset({1: [2, 3], 2: [4], 3: [5], 4: [6], 5: [6]})
hex.is_subdirectly_reducible(), hex.is_subdirectly_reducible(certificate=True)[0]

outputs (True, False).

Change History (7)

comment:1 Changed 6 months ago by mantepse

  • Branch set to u/mantepse/fix_certificate_of_is_subdirectly_reducible

comment:2 Changed 6 months ago by mantepse

  • Authors set to Martin Rubey
  • Commit set to 416b0835bd1e1eb5c2cdc7b0d55700bbf420757d
  • Component changed from PLEASE CHANGE to combinatorics
  • Status changed from new to needs_review
  • Type changed from PLEASE CHANGE to defect
sage: hex = LatticePoset({1: [2, 3], 2: [4], 3: [5], 4: [6], 5: [6]})
sage: hex.is_subdirectly_reducible()
True
sage: hex.is_subdirectly_reducible(certificate=True)
(False,
 (Finite lattice containing 5 elements, Finite lattice containing 5 elements))

is confusing, it should be True, I think.


New commits:

416b083if the lattice is subdirectly reducible, result should be True

comment:3 Changed 6 months ago by chapoton

  • Cc jmantysalo added

comment:4 Changed 6 months ago by jmantysalo

  • Description modified (diff)
  • Reviewers set to Jori Mäntysalo
  • Status changed from needs_review to positive_review

Of course, my bad. Thanks for correcting.

This shows a defect in src/sage/tests/finite_poset.py, I'll open a ticket for that.

comment:5 Changed 6 months ago by jmantysalo

...and stuck with #26854.

comment:6 Changed 6 months ago by vbraun

  • Branch changed from u/mantepse/fix_certificate_of_is_subdirectly_reducible to 416b0835bd1e1eb5c2cdc7b0d55700bbf420757d
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:7 Changed 6 months ago by embray

  • Milestone changed from sage-8.5 to sage-8.6

This tickets were closed as fixed after the Sage 8.5 release.

Note: See TracTickets for help on using tickets.