#26846 closed enhancement (fixed)
py3: fix sparse graph isomorphism
Reported by:  chapoton  Owned by:  

Priority:  major  Milestone:  sage8.6 
Component:  python3  Keywords:  
Cc:  dcoudert, jhpalmieri  Merged in:  
Authors:  Frédéric Chapoton  Reviewers:  David Coudert 
Report Upstream:  N/A  Work issues:  
Branch:  7144171 (Commits, GitHub, GitLab)  Commit:  714417176c21fc2c3518ba3f776304dccb7876ad 
Dependencies:  Stopgaps: 
Description
Change History (17)
comment:1 Changed 3 years ago by
 Branch set to u/chapoton/graphe_iso
 Commit set to fcb62df1eb56b694e7ce77d06e089a2777867000
 Status changed from new to needs_review
comment:2 Changed 3 years ago by
 Status changed from needs_review to needs_work
comment:3 Changed 3 years ago by
 Cc jhpalmieri added
comment:4 Changed 3 years ago by
 Commit changed from fcb62df1eb56b694e7ce77d06e089a2777867000 to 9678120712e2ef79305c96967469af8acd3ea83e
Branch pushed to git repo; I updated commit sha1. New commits:
9678120  trac 26846 fixing a few doctests

comment:5 Changed 3 years ago by
 Summary changed from py3: fix graph isomorphism to py3: fix sparse graph isomorphism
comment:6 Changed 3 years ago by
Unfortunately, the fixed doctests are not the same with python3. The certificate of isomorphism is different. Maybe we should make these doctests more robust and more conceptual.
comment:7 Changed 3 years ago by
Right, we could have some robust doctests to ensure that the result is correct and some # not tested
doctests to illustrate the expected output. There are several places where the output ordering is different in py2 and py3.
comment:8 Changed 3 years ago by
 Commit changed from 9678120712e2ef79305c96967469af8acd3ea83e to 1aeab526b544f3559028767fb8e79e3a4690b476
comment:9 Changed 3 years ago by
 Status changed from needs_work to needs_review
I have removed the dict from some doctests. These doctests are not here to doctest the is_isomorphic
method itself, so I think there is not need to use the certificate. We can either forget it, or just not ask for it..
This does not fix completely the homology folder for python3, but this is still some progress on the way.
comment:10 Changed 3 years ago by
 Commit changed from 1aeab526b544f3559028767fb8e79e3a4690b476 to 5441e6cc5fdf3643c05c055321a0126bae189f34
Branch pushed to git repo; I updated commit sha1. New commits:
5441e6c  trac 26846 do not use .vertices in is_isomorphic

comment:11 Changed 3 years ago by
patchbot is green. This seems to be ready for review now.
comment:12 Changed 3 years ago by
 Reviewers set to David Coudert
apart from the possibly missing empty line between bullets, this patch looks good to me.
+  ``vertices``  a list of vertex labels
+  ``labels``  boolean, whether to return labels as well
comment:13 Changed 3 years ago by
 Commit changed from 5441e6cc5fdf3643c05c055321a0126bae189f34 to 714417176c21fc2c3518ba3f776304dccb7876ad
Branch pushed to git repo; I updated commit sha1. New commits:
7144171  details of doc

comment:14 Changed 3 years ago by
oh, well, here it is..
comment:16 Changed 3 years ago by
 Branch changed from u/chapoton/graphe_iso to 714417176c21fc2c3518ba3f776304dccb7876ad
 Resolution set to fixed
 Status changed from positive_review to closed
comment:17 Changed 3 years ago by
 Milestone changed from sage8.5 to sage8.6
This tickets were closed as fixed after the Sage 8.5 release.
New commits:
py3: trying to fix graph isomorphism