Opened 2 years ago

Closed 2 years ago

#26845 closed enhancement (fixed)

py3: tiny fix for Lie algebras

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.5
Component: python3 Keywords:
Cc: tscrim Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 6182617 (Commits, GitHub, GitLab) Commit: 618261775abc48a2e2b16c83a15532bc396a77af
Dependencies: Stopgaps:

Status badges


by using an ordered dict

Change History (4)

comment:1 Changed 2 years ago by chapoton

  • Branch set to u/chapoton/26845
  • Commit set to 618261775abc48a2e2b16c83a15532bc396a77af
  • Status changed from new to needs_review

New commits:

6182617py3: tentative fix in Lie algebras

comment:2 Changed 2 years ago by tscrim

  • Reviewers set to Travis Scrimshaw

I might be slightly inclined to wrapping the doctests with sorted instead, but I don't have a very strong opinion. So if you feel this is the better fix, then you can set a positive review once the patchbot comes back green.

comment:3 Changed 2 years ago by chapoton

  • Status changed from needs_review to positive_review

Patchbot is green.

The ultimate aim is to make all doctests pass for lie algebras. This is a small positive step, so let us move on.

comment:4 Changed 2 years ago by vbraun

  • Branch changed from u/chapoton/26845 to 618261775abc48a2e2b16c83a15532bc396a77af
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.