#26836 closed enhancement (fixed)

some enhancements to cluster quiver interact

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.5
Component: combinatorics Keywords:
Cc: etn40ff, stumpc5, tscrim Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 02ce422 (Commits) Commit: 02ce422ab9e3d9fe5b857c806606f5788c15c8bd
Dependencies: Stopgaps:

Description

  • make it really work on python3
  • auto-reduce the mutation sequence (mu_i is an involution)
  • interactive choice between spring and circular display
  • adjust the vertex colors (more pastel)

Change History (8)

comment:1 Changed 18 months ago by chapoton

  • Branch set to u/chapoton/26836
  • Commit set to 7ac68cf146f5d701aea47554fb540a6cdb1396db
  • Status changed from new to needs_review

New commits:

7ac68cfsome tiny enhancements to cluster interact

comment:2 Changed 18 months ago by git

  • Commit changed from 7ac68cf146f5d701aea47554fb540a6cdb1396db to 02ce422ab9e3d9fe5b857c806606f5788c15c8bd

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

02ce422some tiny enhancements to cluster interact

comment:3 Changed 18 months ago by stumpc5

Thanks for taking care of this! I don't have any new version of sage, but I am sure Travis has :-)


New commits:

02ce422some tiny enhancements to cluster interact

comment:4 Changed 18 months ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:5 Changed 18 months ago by chapoton

thanks, Travis. Maybe you should have asked me to care for the pyflakes plugin warning ?

comment:6 Changed 18 months ago by tscrim

Probably. If you want to quickly fix that, go ahead, and we can reset to positive.

comment:7 Changed 18 months ago by chapoton

I prefer not to touch anything that is already in positive review.

comment:8 Changed 18 months ago by vbraun

  • Branch changed from u/chapoton/26836 to 02ce422ab9e3d9fe5b857c806606f5788c15c8bd
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.