Opened 2 years ago

Closed 2 years ago

#26833 closed enhancement (fixed)

avoid using .vertices() in vertex_separation.pyx

Reported by: dcoudert Owned by:
Priority: major Milestone: sage-8.5
Component: graph theory Keywords: py3, graph
Cc: Merged in:
Authors: David Coudert Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: a7825df (Commits, GitHub, GitLab) Commit: a7825dfc8c99400cdb17df440fe933a4e70478a2
Dependencies: Stopgaps:

Status badges

Description

To avoid using .vertices(), we change the default ordering of vertices in FastDiGraph and add it's constructor an optional parameter to specify the mapping integer to vertices.

Change History (4)

comment:1 Changed 2 years ago by dcoudert

  • Branch set to public/26833_vertex_separation
  • Commit set to 113af6e9e3063ed8f72d68c848502566ca0bcaaf
  • Status changed from new to needs_review
  • Summary changed from avoid using .vertices in vertex_separation.pyx to avoid using .vertices() in vertex_separation.pyx

New commits:

​113af6etrac #26833: avoid .vertices() in vertex_separation.pyx

comment:2 Changed 2 years ago by git

  • Commit changed from 113af6e9e3063ed8f72d68c848502566ca0bcaaf to a7825dfc8c99400cdb17df440fe933a4e70478a2

Branch pushed to git repo; I updated commit sha1. New commits:

​a7825dftrac #26833: better use of dense_graph_init to avoid call to .vertices()

comment:3 Changed 2 years ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

seems to be ok

comment:4 Changed 2 years ago by vbraun

  • Branch changed from public/26833_vertex_separation to a7825dfc8c99400cdb17df440fe933a4e70478a2
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.