Opened 4 years ago

Closed 4 years ago

#26833 closed enhancement (fixed)

avoid using .vertices() in vertex_separation.pyx

Reported by: David Coudert Owned by:
Priority: major Milestone: sage-8.5
Component: graph theory Keywords: py3, graph
Cc: Merged in:
Authors: David Coudert Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: a7825df (Commits, GitHub, GitLab) Commit: a7825dfc8c99400cdb17df440fe933a4e70478a2
Dependencies: Stopgaps:

Status badges

Description

To avoid using .vertices(), we change the default ordering of vertices in FastDiGraph and add it's constructor an optional parameter to specify the mapping integer to vertices.

Change History (4)

comment:1 Changed 4 years ago by David Coudert

Branch: public/26833_vertex_separation
Commit: 113af6e9e3063ed8f72d68c848502566ca0bcaaf
Status: newneeds_review
Summary: avoid using .vertices in vertex_separation.pyxavoid using .vertices() in vertex_separation.pyx

New commits:

113af6etrac #26833: avoid .vertices() in vertex_separation.pyx

comment:2 Changed 4 years ago by git

Commit: 113af6e9e3063ed8f72d68c848502566ca0bcaafa7825dfc8c99400cdb17df440fe933a4e70478a2

Branch pushed to git repo; I updated commit sha1. New commits:

a7825dftrac #26833: better use of dense_graph_init to avoid call to .vertices()

comment:3 Changed 4 years ago by Frédéric Chapoton

Reviewers: Frédéric Chapoton
Status: needs_reviewpositive_review

seems to be ok

comment:4 Changed 4 years ago by Volker Braun

Branch: public/26833_vertex_separationa7825dfc8c99400cdb17df440fe933a4e70478a2
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.