Opened 10 months ago

Closed 8 months ago

#26822 closed enhancement (fixed)

pep8 cleaning in centrality_betweenness and centrality_closeness

Reported by: dcoudert Owned by:
Priority: major Milestone: sage-8.7
Component: graph theory Keywords:
Cc: Merged in:
Authors: David Coudert Reviewers: Bryan Gin-ge Chen
Report Upstream: N/A Work issues:
Branch: edd746d (Commits) Commit: edd746dbe48fc0aaeaa03cf9b419ce55a41b9174
Dependencies: Stopgaps:

Description

We also avoid some calls to .vertices() that where useless

Change History (7)

comment:1 Changed 10 months ago by dcoudert

  • Branch set to public/26822_centralities
  • Commit set to a128df2b03054a6c6c6ed5b5ee2a3eaff7aec7c4
  • Status changed from new to needs_review

New commits:

a128df2trac #26822: pep8 in centrality_betweenness and centrality_closeness

comment:2 Changed 10 months ago by git

  • Commit changed from a128df2b03054a6c6c6ed5b5ee2a3eaff7aec7c4 to 2df570ce0ac99c2f0585309c31dcbfc13fa91455

Branch pushed to git repo; I updated commit sha1. New commits:

2df570ctrac #26822: fix doctest error in centrality_closeness

comment:3 Changed 10 months ago by dcoudert

For directed graphs, no value is returned for vertices with out-degree 0, but a value is returned for vertices with in-degree 0 and out-degree > 0. The doctest is now fixed.

comment:4 Changed 8 months ago by git

  • Commit changed from 2df570ce0ac99c2f0585309c31dcbfc13fa91455 to edd746dbe48fc0aaeaa03cf9b419ce55a41b9174

Branch pushed to git repo; I updated commit sha1. New commits:

edd746dtrac #26822: Merged with 8.7.beta0

comment:5 Changed 8 months ago by dcoudert

  • Milestone changed from sage-8.5 to sage-8.7

comment:6 Changed 8 months ago by gh-bryangingechen

  • Reviewers set to Bryan Gin-ge Chen
  • Status changed from needs_review to positive_review

This one looks good too.

comment:7 Changed 8 months ago by vbraun

  • Branch changed from public/26822_centralities to edd746dbe48fc0aaeaa03cf9b419ce55a41b9174
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.