Opened 4 years ago

Closed 4 years ago

#26822 closed enhancement (fixed)

pep8 cleaning in centrality_betweenness and centrality_closeness

Reported by: David Coudert Owned by:
Priority: major Milestone: sage-8.7
Component: graph theory Keywords:
Cc: Merged in:
Authors: David Coudert Reviewers: Bryan Gin-ge Chen
Report Upstream: N/A Work issues:
Branch: edd746d (Commits, GitHub, GitLab) Commit: edd746dbe48fc0aaeaa03cf9b419ce55a41b9174
Dependencies: Stopgaps:

Status badges

Description

We also avoid some calls to .vertices() that where useless

Change History (7)

comment:1 Changed 4 years ago by David Coudert

Branch: public/26822_centralities
Commit: a128df2b03054a6c6c6ed5b5ee2a3eaff7aec7c4
Status: newneeds_review

New commits:

a128df2trac #26822: pep8 in centrality_betweenness and centrality_closeness

comment:2 Changed 4 years ago by git

Commit: a128df2b03054a6c6c6ed5b5ee2a3eaff7aec7c42df570ce0ac99c2f0585309c31dcbfc13fa91455

Branch pushed to git repo; I updated commit sha1. New commits:

2df570ctrac #26822: fix doctest error in centrality_closeness

comment:3 Changed 4 years ago by David Coudert

For directed graphs, no value is returned for vertices with out-degree 0, but a value is returned for vertices with in-degree 0 and out-degree > 0. The doctest is now fixed.

comment:4 Changed 4 years ago by git

Commit: 2df570ce0ac99c2f0585309c31dcbfc13fa91455edd746dbe48fc0aaeaa03cf9b419ce55a41b9174

Branch pushed to git repo; I updated commit sha1. New commits:

edd746dtrac #26822: Merged with 8.7.beta0

comment:5 Changed 4 years ago by David Coudert

Milestone: sage-8.5sage-8.7

comment:6 Changed 4 years ago by Bryan Gin-ge Chen

Reviewers: Bryan Gin-ge Chen
Status: needs_reviewpositive_review

This one looks good too.

comment:7 Changed 4 years ago by Volker Braun

Branch: public/26822_centralitiesedd746dbe48fc0aaeaa03cf9b419ce55a41b9174
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.