Opened 4 years ago
Closed 4 years ago
#26822 closed enhancement (fixed)
pep8 cleaning in centrality_betweenness and centrality_closeness
Reported by:  David Coudert  Owned by:  

Priority:  major  Milestone:  sage8.7 
Component:  graph theory  Keywords:  
Cc:  Merged in:  
Authors:  David Coudert  Reviewers:  Bryan Ginge Chen 
Report Upstream:  N/A  Work issues:  
Branch:  edd746d (Commits, GitHub, GitLab)  Commit:  edd746dbe48fc0aaeaa03cf9b419ce55a41b9174 
Dependencies:  Stopgaps: 
Description
We also avoid some calls to .vertices()
that where useless
Change History (7)
comment:1 Changed 4 years ago by
Branch:  → public/26822_centralities 

Commit:  → a128df2b03054a6c6c6ed5b5ee2a3eaff7aec7c4 
Status:  new → needs_review 
comment:2 Changed 4 years ago by
Commit:  a128df2b03054a6c6c6ed5b5ee2a3eaff7aec7c4 → 2df570ce0ac99c2f0585309c31dcbfc13fa91455 

Branch pushed to git repo; I updated commit sha1. New commits:
2df570c  trac #26822: fix doctest error in centrality_closeness

comment:3 Changed 4 years ago by
For directed graphs, no value is returned for vertices with outdegree 0, but a value is returned for vertices with indegree 0 and outdegree > 0. The doctest is now fixed.
comment:4 Changed 4 years ago by
Commit:  2df570ce0ac99c2f0585309c31dcbfc13fa91455 → edd746dbe48fc0aaeaa03cf9b419ce55a41b9174 

Branch pushed to git repo; I updated commit sha1. New commits:
edd746d  trac #26822: Merged with 8.7.beta0

comment:5 Changed 4 years ago by
Milestone:  sage8.5 → sage8.7 

comment:6 Changed 4 years ago by
Reviewers:  → Bryan Ginge Chen 

Status:  needs_review → positive_review 
This one looks good too.
comment:7 Changed 4 years ago by
Branch:  public/26822_centralities → edd746dbe48fc0aaeaa03cf9b419ce55a41b9174 

Resolution:  → fixed 
Status:  positive_review → closed 
Note: See
TracTickets for help on using
tickets.
New commits:
trac #26822: pep8 in centrality_betweenness and centrality_closeness