Opened 4 months ago

Closed 6 weeks ago

#26819 closed enhancement (fixed)

improve method eccentricity to save calls to .vertices()

Reported by: dcoudert Owned by:
Priority: major Milestone: sage-8.7
Component: graph theory Keywords:
Cc: Merged in:
Authors: David Coudert Reviewers: Bryan Gin-ge Chen
Report Upstream: N/A Work issues:
Branch: 5f276c3 (Commits) Commit: 5f276c3411831d13334e8bb8cd423abe60f32e90
Dependencies: Stopgaps:

Description (last modified by dcoudert)

In method eccentricity of distances_all_pairs.pyx:

  • add parameter vertex_list in order to save some calls to .vertices().

In method eccentricity of generic_graph.py:

  • set parameter vertex_list when calling method eccentricity of distances_all_pairs.pyx
  • fix an error in the ordering of returned values (a doctest was false...). This ordering must be consistent with parameter v

Change History (9)

comment:1 Changed 4 months ago by dcoudert

  • Branch set to public/26819_eccentricity
  • Commit set to 74dcdebee014d284d66384573d6fd0e59555012a
  • Description modified (diff)
  • Status changed from new to needs_review

New commits:

​74dcdebtrac #26819: improve eccentricity

comment:2 Changed 3 months ago by git

  • Commit changed from 74dcdebee014d284d66384573d6fd0e59555012a to 37001e842385942cdc45b234ed135d6ccb03350e

Branch pushed to git repo; I updated commit sha1. New commits:

​37001e8trac #26819: fix merge conflict with 8.6.beta1

comment:3 Changed 3 months ago by dcoudert

  • Milestone changed from sage-8.5 to sage-8.6

fix some merge conflicts with 8.6.beta1.

comment:4 Changed 2 months ago by embray

  • Milestone changed from sage-8.6 to sage-8.7

Retarging tickets optimistically to the next milestone. If you are responsible for this ticket (either its reporter or owner) and don't believe you are likely to complete this ticket before the next release (8.7) please retarget this ticket's milestone to sage-pending or sage-wishlist.

comment:5 Changed 8 weeks ago by git

  • Commit changed from 37001e842385942cdc45b234ed135d6ccb03350e to 5f276c3411831d13334e8bb8cd423abe60f32e90

Branch pushed to git repo; I updated commit sha1. New commits:

​5f276c3trac #26819: Merged with 8.7.beta0

comment:6 Changed 8 weeks ago by dcoudert

Rebased on last beta.

comment:7 Changed 7 weeks ago by gh-bryangingechen

  • Reviewers set to Bryan Gin-ge Chen
  • Status changed from needs_review to positive_review

Looks good to me.

comment:8 Changed 7 weeks ago by dcoudert

Thank you.

comment:9 Changed 6 weeks ago by vbraun

  • Branch changed from public/26819_eccentricity to 5f276c3411831d13334e8bb8cd423abe60f32e90
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.