Opened 4 years ago

Closed 3 years ago

#26815 closed enhancement (fixed)

pep8 cleaning in distances and distance_all_pairs

Reported by: dcoudert Owned by:
Priority: major Milestone: sage-8.7
Component: graph theory Keywords:
Cc: Merged in:
Authors: David Coudert Reviewers: Vincent Klein
Report Upstream: N/A Work issues:
Branch: 842f6d6 (Commits, GitHub, GitLab) Commit: 842f6d6f55b5a1b9ccd5ab2a65d1503e39c041c8
Dependencies: Stopgaps:

Status badges


Change History (8)

comment:1 Changed 4 years ago by dcoudert

  • Branch set to public/26815_distances
  • Commit set to bac1b22d359f8a2d9951589999e9f68e3ccf200c
  • Status changed from new to needs_review

New commits:

bac1b22trac #26815: pep8 in distances and distance_all_pairs

comment:2 Changed 3 years ago by dcoudert

  • Milestone changed from sage-8.5 to sage-8.6

comment:3 Changed 3 years ago by embray

  • Milestone changed from sage-8.6 to sage-8.7

Retarging tickets optimistically to the next milestone. If you are responsible for this ticket (either its reporter or owner) and don't believe you are likely to complete this ticket before the next release (8.7) please retarget this ticket's milestone to sage-pending or sage-wishlist.

comment:4 Changed 3 years ago by git

  • Commit changed from bac1b22d359f8a2d9951589999e9f68e3ccf200c to 842f6d6f55b5a1b9ccd5ab2a65d1503e39c041c8

Branch pushed to git repo; I updated commit sha1. New commits:

842f6d6trac #26815: Merged with 8.7.beta3

comment:5 Changed 3 years ago by dcoudert

I rebased this ticket and 8.7.beta3 to ease review and check that its still OK.

comment:6 Changed 3 years ago by vklein

  • Reviewers set to Vincent Klein
  • Status changed from needs_review to positive_review

Looks good to me.

comment:7 Changed 3 years ago by dcoudert

Thank you !

comment:8 Changed 3 years ago by vbraun

  • Branch changed from public/26815_distances to 842f6d6f55b5a1b9ccd5ab2a65d1503e39c041c8
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.