Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#26814 closed enhancement (fixed)

pep8 cleaning of clustering methods

Reported by: David Coudert Owned by:
Priority: major Milestone: sage-8.6
Component: graph theory Keywords:
Cc: Merged in:
Authors: David Coudert Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: d83f778 (Commits, GitHub, GitLab) Commit: d83f778e9542ebd52ec97babe928a617b9687d3a
Dependencies: Stopgaps:

Status badges

Description

we do PEP8 cleaning of methods clustering_average, clustering_coeff and cluster_transitivity.

Change History (11)

comment:1 Changed 4 years ago by David Coudert

Branch: public/26814_clean_clustering_methods
Commit: a97a9b7d4d8db8222ca0baa0e1e65338c6a72f7c
Status: newneeds_review

New commits:

a97a9b7trac #26814: pep8 cleaning in clustering_average, clustering_coeff and cluster_transitivity

comment:2 Changed 4 years ago by Frédéric Chapoton

do not do that

-        TESTS::
+        Empty graph::

because the TESTS section is hidden (not displayed)

comment:3 Changed 4 years ago by git

Commit: a97a9b7d4d8db8222ca0baa0e1e65338c6a72f7c11de534d25f13b98829009c044cd732f9f9bfa4d

Branch pushed to git repo; I updated commit sha1. New commits:

11de534trac #26814: reviewer's comment

comment:4 Changed 4 years ago by David Coudert

You are right, it's better this way.

comment:5 Changed 4 years ago by Frédéric Chapoton

Status: needs_reviewneeds_work

typo ValueEror

otherwise, looks good

comment:6 Changed 4 years ago by git

Commit: 11de534d25f13b98829009c044cd732f9f9bfa4dd83f778e9542ebd52ec97babe928a617b9687d3a

Branch pushed to git repo; I updated commit sha1. New commits:

fe3fba8trac #26814: Merged with 8.5.rc0
d83f778trac #26814: typo

comment:7 Changed 4 years ago by David Coudert

oups, fixed.

comment:8 Changed 4 years ago by Frédéric Chapoton

Reviewers: Frédéric Chapoton
Status: needs_workpositive_review

merci !

comment:9 Changed 4 years ago by David Coudert

Merci à toi ;)

comment:10 Changed 4 years ago by Volker Braun

Branch: public/26814_clean_clustering_methodsd83f778e9542ebd52ec97babe928a617b9687d3a
Resolution: fixed
Status: positive_reviewclosed

comment:11 Changed 4 years ago by Erik Bray

Milestone: sage-8.5sage-8.6

This tickets were closed as fixed after the Sage 8.5 release.

Note: See TracTickets for help on using tickets.