Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#26814 closed enhancement (fixed)

pep8 cleaning of clustering methods

Reported by: dcoudert Owned by:
Priority: major Milestone: sage-8.6
Component: graph theory Keywords:
Cc: Merged in:
Authors: David Coudert Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: d83f778 (Commits, GitHub, GitLab) Commit: d83f778e9542ebd52ec97babe928a617b9687d3a
Dependencies: Stopgaps:

Status badges

Description

we do PEP8 cleaning of methods clustering_average, clustering_coeff and cluster_transitivity.

Change History (11)

comment:1 Changed 3 years ago by dcoudert

  • Branch set to public/26814_clean_clustering_methods
  • Commit set to a97a9b7d4d8db8222ca0baa0e1e65338c6a72f7c
  • Status changed from new to needs_review

New commits:

​a97a9b7trac #26814: pep8 cleaning in clustering_average, clustering_coeff and cluster_transitivity

comment:2 Changed 3 years ago by chapoton

do not do that 

-        TESTS::
+        Empty graph::

because the TESTS section is hidden (not displayed)

comment:3 Changed 3 years ago by git

  • Commit changed from a97a9b7d4d8db8222ca0baa0e1e65338c6a72f7c to 11de534d25f13b98829009c044cd732f9f9bfa4d

Branch pushed to git repo; I updated commit sha1. New commits:

​11de534trac #26814: reviewer's comment

comment:4 Changed 3 years ago by dcoudert

You are right, it's better this way.

comment:5 Changed 3 years ago by chapoton

  • Status changed from needs_review to needs_work

typo ValueEror

otherwise, looks good

comment:6 Changed 3 years ago by git

  • Commit changed from 11de534d25f13b98829009c044cd732f9f9bfa4d to d83f778e9542ebd52ec97babe928a617b9687d3a

Branch pushed to git repo; I updated commit sha1. New commits:

​fe3fba8trac #26814: Merged with 8.5.rc0
​d83f778trac #26814: typo

comment:7 Changed 3 years ago by dcoudert

oups, fixed.

comment:8 Changed 3 years ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_work to positive_review

merci !

comment:9 Changed 3 years ago by dcoudert

Merci à toi ;)

comment:10 Changed 3 years ago by vbraun

  • Branch changed from public/26814_clean_clustering_methods to d83f778e9542ebd52ec97babe928a617b9687d3a
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:11 Changed 3 years ago by embray

  • Milestone changed from sage-8.5 to sage-8.6

This tickets were closed as fixed after the Sage 8.5 release.

Note: See TracTickets for help on using tickets.