Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#26805 closed enhancement (fixed)

py3: Make doctest pass in combinat/rigged_configurations module

Reported by: vklein Owned by:
Priority: major Milestone: sage-8.6
Component: python3 Keywords:
Cc: chapoton Merged in:
Authors: Vincent Klein Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 8596208 (Commits, GitHub, GitLab) Commit: 859620804529bc779d9929e28263185ec23d12ac
Dependencies: Stopgaps:

Status badges

Description (last modified by vklein)

This ticket fix the last py3 failures in combinat/rigged_configurations module.

For the TypeError: unsupported format string passed to sage.rings.rational.Rational.__format__ another approach is to implement a __format__ method in sage.rings.rational.Rational, unfortunately it will not solve the cases with NoneType?. For this reason i think string formatting support for sage's Rational should be done in another ticket if needed.

Change History (13)

comment:1 Changed 3 years ago by vklein

  • Authors set to Vincent Klein

comment:2 Changed 3 years ago by vklein

  • Branch set to u/vklein/26805

comment:3 Changed 3 years ago by vklein

  • Cc chapoton added
  • Commit set to bbb1dc1c8a66c14731dd27bf5883ac3067680d70
  • Description modified (diff)
  • Status changed from new to needs_review

comment:4 Changed 3 years ago by chapoton

  • Reviewers set to Frédéric Chapoton

ok, good to go. But would you please first fix the pyflakes warnings ?

comment:5 Changed 3 years ago by vklein

Sure, i will do it this morning.

comment:6 Changed 3 years ago by git

  • Commit changed from bbb1dc1c8a66c14731dd27bf5883ac3067680d70 to 859620804529bc779d9929e28263185ec23d12ac

Branch pushed to git repo; I updated commit sha1. New commits:

8596208Trac #26805: Remove useless assignement

comment:7 Changed 3 years ago by vklein

@chapoton I commented vct rather than deleting the line to keep consistency with the comments below in the code. Do you think the comments

        # vct = self.parent()._folded_ct
        # sigma = vct.folding_orbit()
        # gammatilde = list(vct.scaling_factors())
        # gammatilde[-1] = 2

are helpful or do you think we should delete them?

comment:8 Changed 3 years ago by chapoton

oh, we can keep them.

green bot => positive review.

Do you have a patchbot at your disposal that you could launch on this ticket ? Mines are already busy right now.

comment:9 Changed 3 years ago by vklein

Not right now (some computing in progress). I will try this afternoon.

comment:10 Changed 3 years ago by vklein

  • Description modified (diff)

comment:11 Changed 3 years ago by vklein

  • Status changed from needs_review to positive_review

comment:12 Changed 3 years ago by vbraun

  • Branch changed from u/vklein/26805 to 859620804529bc779d9929e28263185ec23d12ac
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:13 Changed 3 years ago by embray

  • Milestone changed from sage-8.5 to sage-8.6

This tickets were closed as fixed after the Sage 8.5 release.

Note: See TracTickets for help on using tickets.