#26782 closed defect (fixed)

boost 1.66 does not compile

Reported by: jdemeyer Owned by:
Priority: blocker Milestone: sage-8.5
Component: packages: optional Keywords:
Cc: fbissey Merged in:
Authors: François Bissey Reviewers: Volker Braun
Report Upstream: N/A Work issues:
Branch: 51c9077 (Commits) Commit: 51c907727ccce5df8e82c3e6bdf238c521d671b7
Dependencies: Stopgaps:

Description

./spkg-install: line 55: syntax error near unexpected token `"$(which $C_COMPILER_NAME)"'
./spkg-install: line 55: `    if [ ("$(which $C_COMPILER_NAME)" != "/usr/bin/gcc") -a ("$C_COMPILER_NAME" != "clang") ]; then'

Change History (8)

comment:1 follow-up: Changed 12 months ago by fbissey

Presumably, you get that on OS X. Which version?

comment:2 in reply to: ↑ 1 Changed 12 months ago by jdemeyer

Replying to fbissey:

Presumably, you get that on OS X.

Not quite:

$ uname -a
Linux sage4 4.14.78-gentoo #3 SMP Tue Nov 20 16:05:28 CET 2018 x86_64 Intel(R) Xeon(R) CPU X5660 @ 2.80GHz GenuineIntel GNU/Linux
$ bash --version
GNU bash, version 4.3.48(1)-release (x86_64-pc-linux-gnu)
Copyright (C) 2013 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>

This is free software; you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

comment:3 follow-up: Changed 12 months ago by jdemeyer

The problem seems to be the parentheses inside the [ ... ] which should be quoted but which are really not needed here in the first place.

comment:4 Changed 12 months ago by fbissey

All right, I thought I had tested this. It is time for another check. But I'll take syntax suggestions right now.

comment:5 in reply to: ↑ 3 Changed 12 months ago by fbissey

Replying to jdemeyer:

The problem seems to be the parentheses inside the [ ... ] which should be quoted but which are really not needed here in the first place.

I see, they must have been a late addition because there is no way I didn't at least test that it built with gcc and clang on a linux box.

comment:6 Changed 12 months ago by fbissey

  • Authors set to François Bissey
  • Branch set to u/fbissey/fix_boost
  • Commit set to 51c907727ccce5df8e82c3e6bdf238c521d671b7
  • Status changed from new to needs_review

New commits:

51c9077Fix syntax of spkg-install of boost

comment:7 Changed 12 months ago by vbraun

  • Reviewers set to Volker Braun
  • Status changed from needs_review to positive_review

comment:8 Changed 12 months ago by vbraun

  • Branch changed from u/fbissey/fix_boost to 51c907727ccce5df8e82c3e6bdf238c521d671b7
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.