Opened 2 years ago

Closed 2 years ago

#26781 closed enhancement (fixed)

Py3: Fix several combinat files for python3

Reported by: vklein Owned by:
Priority: major Milestone: sage-8.5
Component: python3 Keywords: thursdaysbdx
Cc: chapoton Merged in:
Authors: Vincent Klein Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 9cae81c (Commits, GitHub, GitLab) Commit: 9cae81cb7a5a541ad508b418c102c00d14a84d4e
Dependencies: Stopgaps:

Status badges

Description (last modified by vklein)

Fix several combinat files for python3 :

  • combinat/backtrack.py
  • combinat/diagram_algebras.py
  • combinat/free_module.py
  • combinat/k_tableau.py
  • combinat/multiset_partition_into_sets_ordered
  • combinat/set_partition.py
  • combinat/sidon_sets.py

Partial fix:

  • combinat/partition_kleshchev.py

Change History (12)

comment:1 Changed 2 years ago by vklein

  • Authors set to Vincent Klein
  • Description modified (diff)

comment:2 Changed 2 years ago by vklein

  • Description modified (diff)

comment:3 Changed 2 years ago by vklein

  • Description modified (diff)

comment:4 Changed 2 years ago by vklein

  • Branch set to u/vklein/26781

comment:5 Changed 2 years ago by vklein

  • Commit set to a7f78f1cf1e7dbdb2e7e097e05829a7f2bc771c6
  • Description modified (diff)
  • Keywords thursdaysbdx added

New commits:

​a7f78f1Trac #26781: fix several combinat files for python3

comment:6 Changed 2 years ago by git

  • Commit changed from a7f78f1cf1e7dbdb2e7e097e05829a7f2bc771c6 to fd418bccc4cc612bdda385462915f345d2a13be3

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​fd418bcTrac #26781: fix several combinat files for python3

comment:7 Changed 2 years ago by git

  • Commit changed from fd418bccc4cc612bdda385462915f345d2a13be3 to 15b5e1a37ffc6bd678b7e91b2447e03ba6b7cdac

Branch pushed to git repo; I updated commit sha1. New commits:

​15b5e1aTrac #26781: set_partition.py use list comprehension ...

comment:8 Changed 2 years ago by vklein

  • Cc chapoton added
  • Status changed from new to needs_review

comment:9 Changed 2 years ago by git

  • Commit changed from 15b5e1a37ffc6bd678b7e91b2447e03ba6b7cdac to 9cae81cb7a5a541ad508b418c102c00d14a84d4e

Branch pushed to git repo; I updated commit sha1. New commits:

​9cae81cTrac #26781: Remove some useless import and assignement

comment:10 Changed 2 years ago by vklein

Pyflakes complaints are fixed.

comment:11 Changed 2 years ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok, let it be.

comment:12 Changed 2 years ago by vbraun

  • Branch changed from u/vklein/26781 to 9cae81cb7a5a541ad508b418c102c00d14a84d4e
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.