#26779 closed enhancement (fixed)
py3: fix graph_input.py and hypergraph_generators.py
| Reported by: | dcoudert | Owned by: | |
|---|---|---|---|
| Priority: | major | Milestone: | sage-8.5 |
| Component: | graph theory | Keywords: | py3, graph |
| Cc: | tscrim, chapoton, embray | Merged in: | |
| Authors: | David Coudert | Reviewers: | Frédéric Chapoton |
| Report Upstream: | N/A | Work issues: | |
| Branch: | 016fa31 (Commits, GitHub, GitLab) | Commit: | |
| Dependencies: | Stopgaps: |
Status badges
Description
doctest errors in hypergraph_generators.py are due to bytes vs str. We add a test in graph_input.py to fix the issue.
Change History (14)
comment:1 Changed 4 years ago by
| Branch: | → public/26779_graph_input |
|---|---|
| Cc: | tscrim chapoton added |
| Commit: | → c58ed7920a65bfde0e651f5393ca165db546bccf |
| Status: | new → needs_review |
comment:2 Changed 4 years ago by
| Cc: | embray added |
|---|
probably, it would be better to use "bytes_to_str"
from sage.cpython.string import bytes_to_str
cc-ing Erik, who knows better about the unicode problem
comment:3 Changed 4 years ago by
If it's safer I can use it. I was not aware of that method. Let me know if I should do the change.
comment:5 Changed 4 years ago by
| Commit: | c58ed7920a65bfde0e651f5393ca165db546bccf → 99e5b330baf3b8a5c7b16107ced5381cba83a2ea |
|---|
comment:6 Changed 4 years ago by
Thank you. I agree is cleaner this way.
comment:7 Changed 4 years ago by
| Reviewers: | → Frédéric Chapoton |
|---|---|
| Status: | needs_review → positive_review |
ok, let it be
comment:8 Changed 4 years ago by
| Status: | positive_review → needs_work |
|---|
Please try to avoid using inline imports if it isn't strictly necessary; see recent discussion about this at https://trac.sagemath.org/ticket/26758#comment:11
comment:9 Changed 4 years ago by
| Commit: | 99e5b330baf3b8a5c7b16107ced5381cba83a2ea → 016fa31eb0083267eaccf15c5a508da5aaabbbb1 |
|---|
Branch pushed to git repo; I updated commit sha1. New commits:
| 016fa31 | trac #26779: move import to module level
|
comment:10 Changed 4 years ago by
| Status: | needs_work → needs_review |
|---|
I have not touched to existing imports. But it could also be done here if needed.
comment:12 Changed 4 years ago by
| Branch: | public/26779_graph_input → 016fa31eb0083267eaccf15c5a508da5aaabbbb1 |
|---|---|
| Resolution: | → fixed |
| Status: | positive_review → closed |
comment:13 Changed 4 years ago by
| Commit: | 016fa31eb0083267eaccf15c5a508da5aaabbbb1 |
|---|
It would also be great to squash trivial changes like those together, although at least in this case both versions are at least valid (it's more of a problem when one commit contains trivial errors).
comment:14 Changed 4 years ago by
Didn't mean to delete that. I think that's a bug in the trac plugin...
I don't know if it's the best way to do it.
New commits:
trac #26779: fix hypergraph generators and graph input