Opened 3 years ago

Last modified 3 years ago

#26770 closed defect

Patch pynac with PR: 336 — at Version 8

Reported by: vklein Owned by:
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: packages: standard Keywords: pynac, python3
Cc: chapoton, embray, rws Merged in:
Authors: Vincent Klein Reviewers:
Report Upstream: N/A Work issues:
Branch: u/vklein/patch_pynac_with_pr__366 (Commits, GitHub, GitLab) Commit: 3907c0bb31edbea6ebb2f03397d731d0f00c80c4
Dependencies: Stopgaps:

Status badges

Description (last modified by chapoton)

Following #25979, this patch apply the modification from E.Bray's PR:336.

This fix bugs in python3 like this one :

sage: log(int(88705158), 4)
1

Change History (8)

comment:1 Changed 3 years ago by vklein

  • Branch set to u/vklein/patch_pynac_with_pr__366

comment:2 Changed 3 years ago by vklein

  • Authors set to Vincent Klein
  • Commit set to 3907c0bb31edbea6ebb2f03397d731d0f00c80c4
  • Status changed from new to needs_review

New commits:

3907c0bTrac #26770: Patch pynac to fix bug with long base ...

comment:3 Changed 3 years ago by vklein

  • Keywords pynac python3 added

comment:4 Changed 3 years ago by gh-timokau

Wouldn't it be better to just cut a new pynac bugfix release? Since it advertises itself as a "Sage Math support library" it doesn't make much sense that sage would have to patch it.

comment:5 Changed 3 years ago by chapoton

  • Cc rws added

comment:6 Changed 3 years ago by embray

For some reason I thought this was already fixed--indeed the solution here would be to release a new pynac.

comment:7 Changed 3 years ago by vklein

This is the best solution of course. My only question is when can we expect a new release?

comment:8 Changed 3 years ago by chapoton

  • Description modified (diff)
  • Summary changed from Patch pynac with PR: 366 to Patch pynac with PR: 336
Note: See TracTickets for help on using tickets.