Opened 3 years ago
Closed 3 years ago
#26770 closed defect (wontfix)
Patch pynac with PR: 336
Reported by: | vklein | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-duplicate/invalid/wontfix |
Component: | packages: standard | Keywords: | pynac, python3 |
Cc: | chapoton, embray, rws | Merged in: | |
Authors: | Vincent Klein | Reviewers: | |
Report Upstream: | N/A | Work issues: | |
Branch: | u/vklein/patch_pynac_with_pr__366 (Commits, GitHub, GitLab) | Commit: | 3907c0bb31edbea6ebb2f03397d731d0f00c80c4 |
Dependencies: | Stopgaps: |
Description (last modified by )
Change History (14)
comment:1 Changed 3 years ago by
- Branch set to u/vklein/patch_pynac_with_pr__366
comment:2 Changed 3 years ago by
- Commit set to 3907c0bb31edbea6ebb2f03397d731d0f00c80c4
- Status changed from new to needs_review
comment:3 Changed 3 years ago by
- Keywords pynac python3 added
comment:4 Changed 3 years ago by
Wouldn't it be better to just cut a new pynac bugfix release? Since it advertises itself as a "Sage Math support library" it doesn't make much sense that sage would have to patch it.
comment:5 Changed 3 years ago by
- Cc rws added
comment:6 Changed 3 years ago by
For some reason I thought this was already fixed--indeed the solution here would be to release a new pynac.
comment:7 Changed 3 years ago by
This is the best solution of course. My only question is when can we expect a new release?
comment:8 Changed 3 years ago by
- Description modified (diff)
- Summary changed from Patch pynac with PR: 366 to Patch pynac with PR: 336
comment:9 Changed 3 years ago by
Patching packages from within Sage is not a bad thing. I just hope my upcoming Pynac upgrade ticket gets more review than this one.
comment:10 follow-up: ↓ 11 Changed 3 years ago by
I disagree, patching packages from within sage *is* a bad thing. It greatly increases the workload for packagers, breaks assumptions of users and may result in confusing upstream bug reports. So at least from my point of view this did get reviewed, with the verdict being "lets just do a proper update instead".
comment:11 in reply to: ↑ 10 Changed 3 years ago by
Replying to gh-timokau:
I disagree, patching packages from within sage *is* a bad thing.
+1 we're trying to reduce the dependence on "sage-the-distribution" which has created an inordinate maintenance burden for the entire community.
comment:12 Changed 3 years ago by
- Milestone changed from sage-8.5 to sage-duplicate/invalid/wontfix
Ok then. Wontfix seems to be the majority view for this ticket
comment:13 Changed 3 years ago by
- Status changed from needs_review to positive_review
comment:14 Changed 3 years ago by
- Resolution set to wontfix
- Status changed from positive_review to closed
New commits:
Trac #26770: Patch pynac to fix bug with long base ...