Opened 3 months ago
Closed 3 months ago
#26768 closed enhancement (fixed)
py3: caring for structure/ doctests
Reported by: | chapoton | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-8.5 |
Component: | python3 | Keywords: | |
Cc: | Merged in: | ||
Authors: | Frédéric Chapoton | Reviewers: | Travis Scrimshaw |
Report Upstream: | N/A | Work issues: | |
Branch: | f5394d4 (Commits) | Commit: | f5394d4d0c5bed7701a41fa44fbea7dbe0cdede8 |
Dependencies: | Stopgaps: |
Description
all but one
Change History (6)
comment:1 Changed 3 months ago by
- Branch set to u/chapoton/26768
- Commit set to 82f94e1c988c233ddf18b74c66c67d2e2addd53d
- Status changed from new to needs_review
comment:2 Changed 3 months ago by
- Reviewers set to Travis Scrimshaw
I don't understand why you now get the deprecation warning for that sum
. However, since that function is deprecated, I would just revert that change. Once done, you can set a positive review.
comment:3 Changed 3 months ago by
- Commit changed from 82f94e1c988c233ddf18b74c66c67d2e2addd53d to f5394d4d0c5bed7701a41fa44fbea7dbe0cdede8
Branch pushed to git repo; I updated commit sha1. New commits:
f5394d4 | trac 26768 fixing the doctest
|
comment:4 Changed 3 months ago by
I have instead added the deprecation warning in the doctest.
With this change, all doctests in structure/ pass both with py2 and py3.
So, even if I do no like at all this mysterious appearance of deprecations, I would rather bear with it right now, in order to make good progress towards python3.
comment:5 Changed 3 months ago by
- Status changed from needs_review to positive_review
That particular change was a micro-optimization/presentation change (unless I am misunderstanding something), so that is why I suggested a revert. However, since this does work, positive review.
comment:6 Changed 3 months ago by
- Branch changed from u/chapoton/26768 to f5394d4d0c5bed7701a41fa44fbea7dbe0cdede8
- Resolution set to fixed
- Status changed from positive_review to closed
New commits:
py3: some care for structure/ doctests