Opened 3 years ago

Closed 3 years ago

#26767 closed enhancement (fixed)

py3: some care for matroids

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.5
Component: python3 Keywords:
Cc: Stefan, Rudi, zgershkoff Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: ee88d36 (Commits, GitHub, GitLab) Commit: ee88d36a61146730e7d6d77429fcbf227f87752b
Dependencies: Stopgaps:

Status badges

Description

by changing the way the repr is sorted.

Change History (8)

comment:1 Changed 3 years ago by chapoton

  • Branch set to u/chapoton/26767
  • Commit set to 50bf0ad8667e4acaa652a1a2c746d6e9508d564b
  • Status changed from new to needs_review

New commits:

​816bc5cpy3: some fixes for matroids
​50bf0adfixing many doctests in matroids (change of repr for py3)

comment:2 Changed 3 years ago by chapoton

  • Cc Stefan Rudi zgershkoff added

comment:3 Changed 3 years ago by chapoton

  • Component changed from PLEASE CHANGE to python3

comment:4 Changed 3 years ago by tscrim

  • Reviewers set to Travis Scrimshaw

Could you reintroduce breaks into the long line outputs? Otherwise LGTM.

comment:5 Changed 3 years ago by git

  • Commit changed from 50bf0ad8667e4acaa652a1a2c746d6e9508d564b to ee88d36a61146730e7d6d77429fcbf227f87752b

Branch pushed to git repo; I updated commit sha1. New commits:

​ee88d36trac 26767 cutting the doctests at 80 colons

comment:6 Changed 3 years ago by chapoton

ok, done and double checked.

comment:7 Changed 3 years ago by tscrim

  • Status changed from needs_review to positive_review

Thank you.

comment:8 Changed 3 years ago by vbraun

  • Branch changed from u/chapoton/26767 to ee88d36a61146730e7d6d77429fcbf227f87752b
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.