Opened 3 years ago
Closed 3 years ago
#26747 closed enhancement (fixed)
py3: final fixes for cluster_algebra.py
Reported by:  chapoton  Owned by:  

Priority:  minor  Milestone:  sage8.5 
Component:  python3  Keywords:  
Cc:  etn40ff  Merged in:  
Authors:  Frédéric Chapoton  Reviewers:  Salvatore Stella 
Report Upstream:  N/A  Work issues:  
Branch:  7794060 (Commits, GitHub, GitLab)  Commit:  7794060134985d8b8b70838de2845953c0970af8 
Dependencies:  Stopgaps: 
Description
by adding some #random, because the answer (a path) depends on the behaviour of an iterator. Also making the hash doctest more robust.
This fixes the last 5 failing doctests in this file.
Change History (10)
comment:1 Changed 3 years ago by
 Branch set to u/chapoton/26747
 Commit set to a57ddd3e8e018348e8078dc831f8cd1a86721676
 Status changed from new to needs_review
comment:2 Changed 3 years ago by
 Commit changed from a57ddd3e8e018348e8078dc831f8cd1a86721676 to 3a6f494ac1d4dbc1e22b0ecbebdbc639f6c7f6d3
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
3a6f494  py3 fixes for cluster algebra.py

comment:3 Changed 3 years ago by
comment:4 Changed 3 years ago by
I am not sure the outputs are really random because the algorithm goes through the vertices in width first and neighbouring vertices are labeled always in the same way.
Mathematically the # random
is justified thus LGTM
comment:5 Changed 3 years ago by
 Branch changed from u/chapoton/26747 to u/etn40ff/26747
 Commit changed from 3a6f494ac1d4dbc1e22b0ecbebdbc639f6c7f6d3 to d01cdce26fa52dd11a5ae2e0a2ef8712cd80a8e1
Looking at it more carefully one of the changes you made was not complete.
New commits:
d01cdce  Fix random doctest

comment:6 Changed 3 years ago by
 Commit changed from d01cdce26fa52dd11a5ae2e0a2ef8712cd80a8e1 to 2a971d9e6ac7d2f5f5ea742e2ce3aa43ee11525f
Branch pushed to git repo; I updated commit sha1. New commits:
2a971d9  Still not perfect yet

comment:7 Changed 3 years ago by
 Commit changed from 2a971d9e6ac7d2f5f5ea742e2ce3aa43ee11525f to 7794060134985d8b8b70838de2845953c0970af8
Branch pushed to git repo; I updated commit sha1. New commits:
7794060  One more

comment:8 Changed 3 years ago by
The random is required because python3 gives other (valid) mutation sequences.
ok, good enough for me. Please set to positive if you agree. The patchbot is green.
comment:9 Changed 3 years ago by
 Reviewers set to Salvatore Stella
 Status changed from needs_review to positive_review
comment:10 Changed 3 years ago by
 Branch changed from u/etn40ff/26747 to 7794060134985d8b8b70838de2845953c0970af8
 Resolution set to fixed
 Status changed from positive_review to closed
New commits:
py3: fix doctest in grossman larsson