Opened 3 years ago

Closed 3 years ago

#26744 closed enhancement (fixed)

remove a bunch of deprecated renamed keywords

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.5
Component: refactoring Keywords:
Cc: tscrim, jmantysalo, vklein Merged in:
Authors: Frédéric Chapoton Reviewers: Vincent Klein
Report Upstream: N/A Work issues:
Branch: 82094ee (Commits, GitHub, GitLab) Commit: 82094eea051e881cecae545bee64e1ec052cff62
Dependencies: Stopgaps:

Status badges

Change History (10)

comment:1 Changed 3 years ago by chapoton

  • Branch set to u/chapoton/26744
  • Commit set to 646ee0d140654eb3120dc4c43c182bac623cbb70
  • Status changed from new to needs_review

New commits:

646ee0dremove a bunch of old deprecated renamed keywords

comment:2 Changed 3 years ago by git

  • Commit changed from 646ee0d140654eb3120dc4c43c182bac623cbb70 to 82094eea051e881cecae545bee64e1ec052cff62

Branch pushed to git repo; I updated commit sha1. New commits:

82094eeone more deprecated rename removed

comment:3 Changed 3 years ago by chapoton

  • Description modified (diff)

comment:4 Changed 3 years ago by chapoton

  • Cc tscrim jmantysalo added

green bot, please review

comment:5 Changed 3 years ago by chapoton

  • Cc vklein added

comment:6 Changed 3 years ago by jmantysalo

  • Reviewers set to Jori Mäntysalo

I can take this one.

comment:7 follow-up: Changed 3 years ago by vklein

I am ok to set it to positive review.

@jmantysalo: I let you set this ticket status after your own review.

comment:8 in reply to: ↑ 7 Changed 3 years ago by jmantysalo

  • Reviewers Jori Mäntysalo deleted

Replying to vklein:

I am ok to set it to positive review.

Then by all means do that.

comment:9 Changed 3 years ago by vklein

  • Reviewers set to Vincent Klein
  • Status changed from needs_review to positive_review

Ok.

comment:10 Changed 3 years ago by vbraun

  • Branch changed from u/chapoton/26744 to 82094eea051e881cecae545bee64e1ec052cff62
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.