Opened 3 years ago

Closed 3 years ago

#26743 closed defect (fixed)

cyclotomic_part should not include powers of x

Reported by: kedlaya Owned by:
Priority: major Milestone: sage-8.5
Component: algebra Keywords: polynomials, cyclotomic part
Cc: Merged in:
Authors: Frédéric Chapoton Reviewers: Kiran Kedlaya
Report Upstream: N/A Work issues:
Branch: c21f207 (Commits, GitHub, GitLab) Commit: c21f20784834414e9c7b23e74d974d65313b510b
Dependencies: Stopgaps:

Status badges

Description

The cyclotomic_part function that I introduced in #20263 needs a tweak:

sage: P.<x> = PolynomialRing(QQ)
sage: f = x*(x-1)*(x+2)
sage: f.cyclotomic_part()
x^2-x

Namely, the factor of x should be removed.

Change History (4)

comment:1 Changed 3 years ago by chapoton

  • Authors set to Frédéric Chapoton
  • Branch set to u/chapoton/26743
  • Commit set to c21f20784834414e9c7b23e74d974d65313b510b
  • Status changed from new to needs_review

here is a proposal


New commits:

c21f207trac 27643 fix proposal for cyclotomic_part

comment:2 Changed 3 years ago by kedlaya

That looks fine. As soon as you can verify that it builds and passes doctests, give it a positive review on my behalf.

comment:3 Changed 3 years ago by chapoton

  • Reviewers set to Kiran Kedlaya
  • Status changed from needs_review to positive_review

bot is green, so positive review

comment:4 Changed 3 years ago by vbraun

  • Branch changed from u/chapoton/26743 to c21f20784834414e9c7b23e74d974d65313b510b
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.