Opened 13 months ago
Closed 13 months ago
#26739 closed enhancement (fixed)
py3: some fixes in MonskyWashnitzer
Reported by:  chapoton  Owned by:  

Priority:  major  Milestone:  sage8.5 
Component:  python3  Keywords:  
Cc:  kedlaya, tscrim  Merged in:  
Authors:  Frédéric Chapoton  Reviewers:  Travis Scrimshaw 
Report Upstream:  N/A  Work issues:  
Branch:  395631d (Commits)  Commit:  395631d3b51e074089d85737411e44a99f661132 
Dependencies:  Stopgaps: 
Description
Change History (8)
comment:1 Changed 13 months ago by
 Branch set to u/chapoton/26739
 Commit set to 746a591ec5cb0ff8b5cf4f043cc4d7472436fcf9
 Status changed from new to needs_review
comment:2 Changed 13 months ago by
 Cc kedlaya added
Apart from cosmetic changes, this modifies the computation of the adjusted precision by using floor(...) instead of int(...). Is this mathematically correct ?
comment:3 Changed 13 months ago by
As far as I know there is no mathematical difference.
comment:4 Changed 13 months ago by
 Cc tscrim added
ok, then. The bot is green, please someone review.
comment:5 Changed 13 months ago by
 Reviewers set to Travis Scrimshaw
I know this is a bit beyond the scope of this ticket, but can we move the
floor(Integer(2 * prec  3).log(p))  1
outside of the while loop (and before the if prec <= 2
?
If you don't want to do this, you can set to a positive review. Likewise, once done, you can set a positive review.
comment:6 Changed 13 months ago by
 Commit changed from 746a591ec5cb0ff8b5cf4f043cc4d7472436fcf9 to 395631d3b51e074089d85737411e44a99f661132
Branch pushed to git repo; I updated commit sha1. New commits:
395631d  trac 26739 reviewer suggestion

comment:7 Changed 13 months ago by
 Status changed from needs_review to positive_review
indeed.. Thanks! All done, setting to positive.
comment:8 Changed 13 months ago by
 Branch changed from u/chapoton/26739 to 395631d3b51e074089d85737411e44a99f661132
 Resolution set to fixed
 Status changed from positive_review to closed
New commits:
py3: some fixes in MonskyWashnitzer