Opened 3 years ago

Closed 3 years ago

#26739 closed enhancement (fixed)

py3: some fixes in Monsky-Washnitzer

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.5
Component: python3 Keywords:
Cc: kedlaya, tscrim Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 395631d (Commits, GitHub, GitLab) Commit: 395631d3b51e074089d85737411e44a99f661132
Dependencies: Stopgaps:

Status badges


Change History (8)

comment:1 Changed 3 years ago by chapoton

  • Branch set to u/chapoton/26739
  • Commit set to 746a591ec5cb0ff8b5cf4f043cc4d7472436fcf9
  • Status changed from new to needs_review

New commits:

746a591py3: some fixes in Monsky-Washnitzer

comment:2 Changed 3 years ago by chapoton

  • Cc kedlaya added

Apart from cosmetic changes, this modifies the computation of the adjusted precision by using floor(...) instead of int(...). Is this mathematically correct ?

comment:3 Changed 3 years ago by kedlaya

As far as I know there is no mathematical difference.

comment:4 Changed 3 years ago by chapoton

  • Cc tscrim added

ok, then. The bot is green, please someone review.

comment:5 Changed 3 years ago by tscrim

  • Reviewers set to Travis Scrimshaw

I know this is a bit beyond the scope of this ticket, but can we move the

floor(Integer(2 * prec - 3).log(p)) - 1

outside of the while loop (and before the if prec <= 2?

If you don't want to do this, you can set to a positive review. Likewise, once done, you can set a positive review.

comment:6 Changed 3 years ago by git

  • Commit changed from 746a591ec5cb0ff8b5cf4f043cc4d7472436fcf9 to 395631d3b51e074089d85737411e44a99f661132

Branch pushed to git repo; I updated commit sha1. New commits:

395631dtrac 26739 reviewer suggestion

comment:7 Changed 3 years ago by chapoton

  • Status changed from needs_review to positive_review

indeed.. Thanks! All done, setting to positive.

comment:8 Changed 3 years ago by vbraun

  • Branch changed from u/chapoton/26739 to 395631d3b51e074089d85737411e44a99f661132
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.