Opened 4 years ago

Closed 4 years ago

#26724 closed enhancement (fixed)

py3: one small fix for elliptic curves over number fields

Reported by: Frédéric Chapoton Owned by:
Priority: major Milestone: sage-8.5
Component: python3 Keywords:
Cc: John Cremona Merged in:
Authors: Frédéric Chapoton Reviewers: John Cremona
Report Upstream: N/A Work issues:
Branch: 1331b64 (Commits, GitHub, GitLab) Commit: 1331b648f57f2adbac6d32faef86f445e2f3f6df
Dependencies: Stopgaps:

Status badges

Description

namely one bad map

plus some cosmetic changes

Change History (4)

comment:1 Changed 4 years ago by Frédéric Chapoton

Branch: u/chapoton/26724
Commit: 1331b648f57f2adbac6d32faef86f445e2f3f6df
Status: newneeds_review

New commits:

1331b64py3: one small fix for elliptic curves over number fields

comment:2 Changed 4 years ago by John Cremona

Reviewers: John Cremona
Status: needs_reviewpositive_review

Looks good to me -- 99% cosmetic changes, right?

comment:3 Changed 4 years ago by Frédéric Chapoton

yes, indeed. Until the very last line.. ;)

Last edited 4 years ago by Frédéric Chapoton (previous) (diff)

comment:4 Changed 4 years ago by Volker Braun

Branch: u/chapoton/267241331b648f57f2adbac6d32faef86f445e2f3f6df
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.