Opened 3 years ago

Closed 3 years ago

#26724 closed enhancement (fixed)

py3: one small fix for elliptic curves over number fields

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.5
Component: python3 Keywords:
Cc: cremona Merged in:
Authors: Frédéric Chapoton Reviewers: John Cremona
Report Upstream: N/A Work issues:
Branch: 1331b64 (Commits, GitHub, GitLab) Commit: 1331b648f57f2adbac6d32faef86f445e2f3f6df
Dependencies: Stopgaps:

Status badges

Description

namely one bad map

plus some cosmetic changes

Change History (4)

comment:1 Changed 3 years ago by chapoton

  • Branch set to u/chapoton/26724
  • Commit set to 1331b648f57f2adbac6d32faef86f445e2f3f6df
  • Status changed from new to needs_review

New commits:

1331b64py3: one small fix for elliptic curves over number fields

comment:2 Changed 3 years ago by cremona

  • Reviewers set to John Cremona
  • Status changed from needs_review to positive_review

Looks good to me -- 99% cosmetic changes, right?

comment:3 Changed 3 years ago by chapoton

yes, indeed. Until the very last line.. ;)

Last edited 3 years ago by chapoton (previous) (diff)

comment:4 Changed 3 years ago by vbraun

  • Branch changed from u/chapoton/26724 to 1331b648f57f2adbac6d32faef86f445e2f3f6df
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.